Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1247892

Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property

From Sudeep Holla <sudeep.holla@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property
Date 2015-10-15 17:30 +0200
Message-ID <qjSDF-1Zy-35@gated-at.bofh.it> (permalink)
References <qj7Y5-819-5@gated-at.bofh.it> <qjSaC-19v-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Arnd,

On 15/10/15 15:57, Linus Walleij wrote:
> On Tue, Oct 13, 2015 at 3:32 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>
>> The keyboard driver for GPIO buttons(gpio-keys) checks for one of the
>> two boolean properties to enable gpio buttons as wakeup source:
>> 1. "wakeup-source" or
>> 2. the legacy "gpio-key,wakeup"
>>
>> However juno, ste-snowball and emev2-kzm9d dts file have a undetected
>> "wakeup" property to indicate the wakeup source.
>>
>> This patch fixes it by making use of "wakeup-source" property.
>>
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Magnus Damm <magnus.damm@gmail.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
> OK nice,
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>

Can you pick this up as fix for v4.3 with Ack from Simon and Linus
Walleij ? I will repost 2/2 as a part of bigger cleanup for v4.4

-- 
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 15:40 +0200
  [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 15:40 +0200
    Re: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Rob Herring <robh@kernel.org> - 2015-10-13 16:10 +0200
      Re: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 16:30 +0200
    [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 16:40 +0200
      Re: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with  wakeup-source property Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-13 17:10 +0200
      Re: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property Heiko Stübner <heiko@sntech.de> - 2015-10-13 20:00 +0200
  Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Simon Horman <horms@verge.net.au> - 2015-10-14 02:20 +0200
    Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-14 11:10 +0200
  Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-14 17:30 +0200
  Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Linus Walleij <linus.walleij@linaro.org> - 2015-10-15 17:00 +0200
    Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-15 17:30 +0200

csiph-web