Re: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean

From	Sudeep Holla <sudeep.holla@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean
Date	2015-10-13 16:30 +0200
Message-ID	<qj8Ku-KS-5@gated-at.bofh.it> (permalink)
References	<qj7Y5-819-5@gated-at.bofh.it> <qj7Y6-819-19@gated-at.bofh.it> <qj8r9-ok-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 13/10/15 15:07, Rob Herring wrote:
> On Tue, Oct 13, 2015 at 8:32 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy
>> "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup
>> source.
>>
>> Few dts files assign value "1" to gpio-key,wakeup and in one instance a
>> value "0" is assigned probably assuming it won't be enabled as a wakeup
>> source. Since the presence of the boolean property indicates it is
>> enabled, value of "0" have no value.
>>
>> This patch removes the property where value "0" is assigned and removes
>> the value "1" in most of the other cases.
>
> Why don't you just change everything to wakeup-source.
>

Agreed, I wanted to do that but was not sure if that's acceptable.
I will update it, now I know that you are fine with it.

I also plan to find all the variety of bindings we have and fix them
retaining only those which are handled in the current kernel code as
legacy support.

-- 
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 15:40 +0200
  [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 15:40 +0200
    Re: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Rob Herring <robh@kernel.org> - 2015-10-13 16:10 +0200
      Re: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 16:30 +0200
    [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 16:40 +0200
      Re: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with  wakeup-source property Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-13 17:10 +0200
      Re: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property Heiko Stübner <heiko@sntech.de> - 2015-10-13 20:00 +0200
  Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Simon Horman <horms@verge.net.au> - 2015-10-14 02:20 +0200
    Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-14 11:10 +0200
  Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-14 17:30 +0200
  Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Linus Walleij <linus.walleij@linaro.org> - 2015-10-15 17:00 +0200
    Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-15 17:30 +0200

csiph-web