Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245829

Re: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property

Show all headers | View raw

On 13-10-15, 15:38, Sudeep Holla wrote:
> Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy
> "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup
> source.
> 
> Few dts files assign value "1" to gpio-key,wakeup and in one instance a
> value "0" is assigned probably assuming it won't be enabled as a wakeup
> source. Since the presence of the boolean property indicates it is
> enabled, value of "0" have no value.
> 
> This patch replaces the legacy "gpio-key,wakeup" with the unified
> "wakeup-source" property which inturn fixes the above mentioned issue.
> 
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-rockchip@lists.infradead.org
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  arch/arm/boot/dts/spear1310-evb.dts         | 2 +-
>  arch/arm/boot/dts/spear1340-evb.dts         | 2 +-
>  arch/arm/boot/dts/spear320-hmi.dts          | 4 ++--

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 15:40 +0200
  [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 15:40 +0200
    Re: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Rob Herring <robh@kernel.org> - 2015-10-13 16:10 +0200
      Re: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 16:30 +0200
    [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-13 16:40 +0200
      Re: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with  wakeup-source property Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-13 17:10 +0200
      Re: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property Heiko Stübner <heiko@sntech.de> - 2015-10-13 20:00 +0200
  Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Simon Horman <horms@verge.net.au> - 2015-10-14 02:20 +0200
    Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-14 11:10 +0200
  Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-14 17:30 +0200
  Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Linus Walleij <linus.walleij@linaro.org> - 2015-10-15 17:00 +0200
    Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-15 17:30 +0200

csiph-web