Re: [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load

From	Frederic Weisbecker <fweisbec@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load
Date	2015-10-13 17:00 +0200
Message-ID	<qj9dx-1jL-37@gated-at.bofh.it> (permalink)
References	(3 earlier) <qfLr4-1dr-1@gated-at.bofh.it> <qg9a2-1Gp-5@gated-at.bofh.it> <qiPou-64e-15@gated-at.bofh.it> <qj1SG-7Dx-15@gated-at.bofh.it> <qj3hL-19c-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 13, 2015 at 05:37:18PM +0900, Byungchul Park wrote:
> > > find out the pending updates from update_process_times() itself and pass
> > > it to scheduler_tick() which is the one interested in it.
> > 
> > tick_nohz_handler() calls tick_sched_handler() ?!
> > 
> > And tick_nohz_handler() actually computes the number of ticks -- which
> > we then happily ignore.
> > 
> > Why compute it again a few functions down?
> 
> i think so.
> 
> additionally, i think it would be better to assume that scheduler_tick()
> handles 1 tick as peter said e.g. because of virt, and to handle the
> case caused by full NOHZ *in the nohz related code*.

You mean "not to assume" right?

> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-12 19:50 +0200
  Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Peter Zijlstra <peterz@infradead.org> - 2015-10-13 09:10 +0200
    Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Byungchul Park <byungchul.park@lge.com> - 2015-10-13 10:40 +0200
      Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-13 17:00 +0200
    Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-13 17:00 +0200
      Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Peter Zijlstra <peterz@infradead.org> - 2015-10-13 17:00 +0200

csiph-web