Re: [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load

From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load
Date	2015-10-13 10:40 +0200
Message-ID	<qj3hL-19c-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <qfb4d-8hp-3@gated-at.bofh.it> <qfLr4-1dr-1@gated-at.bofh.it> <qg9a2-1Gp-5@gated-at.bofh.it> <qiPou-64e-15@gated-at.bofh.it> <qj1SG-7Dx-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 13, 2015 at 09:04:36AM +0200, Peter Zijlstra wrote:
> On Mon, Oct 12, 2015 at 07:45:35PM +0200, Frederic Weisbecker wrote:
> > > I think it will take more than a single patch to rework all of
> > > update_process_times(). And we should also ask Thomas for his opinion,
> > > but I think we want:
> > > 
> > > 	- make update_process_times() take a nr_ticks argument
> > > 	  - fixup everything below it
> > > 
> > > 	- fix tick_nohz_handler to not ignore the hrtimer_forward()
> > > 	  return value and pass it into
> > > 	  tick_sched_handle()/update_process_times().
> > > 
> > > 	  (assuming this is the right oneshot tick part, tick-common
> > > 	  seems to be about periodic timers which aren't used much ?!)
> > 
> > this_nohz_handler() is the low res nohz handler. tick_sched_handle()
> > is the high res one (I should rename these). I think we should rather

i also think frederic was confused..

> > find out the pending updates from update_process_times() itself and pass
> > it to scheduler_tick() which is the one interested in it.
> 
> tick_nohz_handler() calls tick_sched_handler() ?!
> 
> And tick_nohz_handler() actually computes the number of ticks -- which
> we then happily ignore.
> 
> Why compute it again a few functions down?

i think so.

additionally, i think it would be better to assume that scheduler_tick()
handles 1 tick as peter said e.g. because of virt, and to handle the
case caused by full NOHZ *in the nohz related code*.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-12 19:50 +0200
  Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Peter Zijlstra <peterz@infradead.org> - 2015-10-13 09:10 +0200
    Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Byungchul Park <byungchul.park@lge.com> - 2015-10-13 10:40 +0200
      Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-13 17:00 +0200
    Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-13 17:00 +0200
      Re: [PATCH v3 2/2] sched: consider missed ticks when updating global  cpu load Peter Zijlstra <peterz@infradead.org> - 2015-10-13 17:00 +0200

csiph-web