[RFC 0/4] x86: sigcontext SS fixes, take 2

From	Andy Lutomirski <luto@kernel.org>
Newsgroups	linux.kernel
Subject	[RFC 0/4] x86: sigcontext SS fixes, take 2
Date	2015-10-13 03:10 +0200
Message-ID	<qiWgi-7NK-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

This is take 2 at fixing x86 64-bit signals wrt SS.  After a lot of
thought, this is not controlled by any flags -- I would much prefer
to avoid opt-in behavior.  Instead, it just tries hard to avoid
triggering the cases that break DOSEMU.

Stas, what do you think?  Could you test this?  It applies on top of
tip:x86/asm.  You can also find it at
https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/sigcontext&id=fd69bc4e6095d6a7cf2a0f03e69bace025505132

With this applied, all of the x86 selftests pass on x86_64.  That
wasn't the case before -- ldt_gdt_64 was broken.

This is a bit risky, and another option would be to do nothing at
all.  Then we'd disable the problematic self-tests (sigh), and
DOSEMU and similar tools will be stuck using gross hacks even on new
kernels.

Andy Lutomirski (4):
  x86/signal/64: Add a comment about sigcontext->fs and gs
  x86/signal/64: Fix SS if needed when delivering a 64-bit signal
  x86/signal/64: Re-add support for SS in the 64-bit signal context
  selftests/x86: Add tests for UC_SIGCONTEXT_SS and UC_STRICT_RESTORE_SS

 arch/x86/include/asm/desc_defs.h        |  23 +++
 arch/x86/include/asm/sigcontext.h       |   2 +-
 arch/x86/include/asm/sighandling.h      |   1 -
 arch/x86/include/uapi/asm/sigcontext.h  |  23 ++-
 arch/x86/include/uapi/asm/ucontext.h    |  41 +++++-
 arch/x86/kernel/signal.c                | 115 ++++++++++++---
 tools/testing/selftests/x86/Makefile    |   4 +-
 tools/testing/selftests/x86/sigreturn.c | 240 ++++++++++++++++++++++++++++----
 8 files changed, 389 insertions(+), 60 deletions(-)

-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC 0/4] x86: sigcontext SS fixes, take 2 Andy Lutomirski <luto@kernel.org> - 2015-10-13 03:10 +0200
  [RFC 4/4] selftests/x86: Add tests for UC_SIGCONTEXT_SS and UC_STRICT_RESTORE_SS Andy Lutomirski <luto@kernel.org> - 2015-10-13 03:10 +0200
  [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit signal context Andy Lutomirski <luto@kernel.org> - 2015-10-13 03:10 +0200
    Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Stas Sergeev <stsp@list.ru> - 2015-10-13 18:10 +0200
      Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Ingo Molnar <mingo@kernel.org> - 2015-10-14 17:10 +0200
        Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Stas Sergeev <stsp@list.ru> - 2015-10-14 17:20 +0200
      Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Andy Lutomirski <luto@amacapital.net> - 2015-10-14 18:50 +0200
        Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Stas Sergeev <stsp@list.ru> - 2015-10-14 19:50 +0200
          Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Andy Lutomirski <luto@amacapital.net> - 2015-10-14 20:10 +0200
            Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Stas Sergeev <stsp@list.ru> - 2015-10-14 20:40 +0200
              Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Andy Lutomirski <luto@amacapital.net> - 2015-10-14 21:00 +0200
                Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Stas Sergeev <stsp@list.ru> - 2015-10-14 23:40 +0200
                Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Andy Lutomirski <luto@amacapital.net> - 2015-10-14 23:50 +0200
    Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Cyrill Gorcunov <gorcunov@gmail.com> - 2015-10-14 18:50 +0200
      Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Andy Lutomirski <luto@amacapital.net> - 2015-10-14 18:50 +0200
        Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Cyrill Gorcunov <gorcunov@gmail.com> - 2015-10-14 19:00 +0200
      Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Stas Sergeev <stsp@list.ru> - 2015-10-14 19:00 +0200
        Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit  signal context Cyrill Gorcunov <gorcunov@gmail.com> - 2015-10-14 19:10 +0200
  [RFC 2/4] x86/signal/64: Fix SS if needed when delivering a 64-bit signal Andy Lutomirski <luto@kernel.org> - 2015-10-13 03:10 +0200

csiph-web