Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap
Date	Mon, 12 Oct 2015 20:00:03 +0200
Message-ID	<qiPyb-6fF-25@gated-at.bofh.it> (permalink)
References	<qhOkN-73l-3@gated-at.bofh.it> <qhOkO-73l-13@gated-at.bofh.it>
X-Original-To	Dan Williams <dan.j.williams@intel.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=zXqDbasuFxne/oVp6ct1NcTiprcaujiWJj40UXLQqo4=; b=enjbosJansxZvZXsFTLvuODmm6sEGPLBEkyIX/+UruUJw5s8F6wwEY9bjCRH0gnGQs ROvkvYqEsmPlzqaH7B5YU4Nqn8DSmr1CLqHi8Zi3p1SD5VNhi9YGB7db9h83tZRz6yXt HiRMlTaQme4D9D/+J0AajofdTzqZx96wzAiDIySNtTmQWfIN/egNKkMc47vxrd/zQ9I5 qGA8yM9jjwDKUukzOz5JxyKFvbWRmY36ZMPndx2vl1XCrvkc+WwplWsX6vNywkQZvXaG YRYAYtZd5tgTHeVzqzvayuJeg7+aYFS3DLCfLAC4lJ2Xa2W3go01TJ/uneKDzX/+hpNZ 0zYw==
X-Received	by 10.68.57.197 with SMTP id k5mr35426204pbq.142.1444672686267; Mon, 12 Oct 2015 10:58:06 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org
X-Original-Date	Mon, 12 Oct 2015 10:58:03 -0700
X-Original-Message-ID	<20151012175803.GL107187@google.com>
X-Original-References	<20151009221537.32203.5867.stgit@dwillia2-desk3.jf.intel.com> <20151009221651.32203.63446.stgit@dwillia2-desk3.jf.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1244966

Show key headers only | View raw

You missed linux-mtd again. Please use scripts/get_maintainer.pl next
time to at least get the relevant mailing list(s). (The individual CC's
are not always necessary, but the subsystem lists definitely are.)

Brian

On Fri, Oct 09, 2015 at 06:16:51PM -0400, Dan Williams wrote:
> In preparation for deprecating ioremap_cache() convert its usage in
> pxa2xx-flash to memremap.
> 
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> [brian: also convert iounmap to memunmap]
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/mtd/maps/pxa2xx-flash.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
> index 12fa75df5008..5ff6cc5b4844 100644
> --- a/drivers/mtd/maps/pxa2xx-flash.c
> +++ b/drivers/mtd/maps/pxa2xx-flash.c
> @@ -71,8 +71,8 @@ static int pxa2xx_flash_probe(struct platform_device *pdev)
>  		       info->map.name);
>  		return -ENOMEM;
>  	}
> -	info->map.cached =
> -		ioremap_cache(info->map.phys, info->map.size);
> +	info->map.cached = memremap(info->map.phys, info->map.size,
> +			MEMREMAP_WB);
>  	if (!info->map.cached)
>  		printk(KERN_WARNING "Failed to ioremap cached %s\n",
>  		       info->map.name);
> @@ -111,7 +111,7 @@ static int pxa2xx_flash_remove(struct platform_device *dev)
>  	map_destroy(info->mtd);
>  	iounmap(info->map.virt);
>  	if (info->map.cached)
> -		iounmap(info->map.cached);
> +		memunmap(info->map.cached);
>  	kfree(info);
>  	return 0;
>  }
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 00/20] tree-wide convert to memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 09/20] i915: switch from acpi_os_ioremap to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
    Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap Daniel Vetter <daniel@ffwll.ch> - 2015-10-12 09:00 +0200
      Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap "Williams, Dan J" <dan.j.williams@intel.com> - 2015-10-12 23:20 +0200
        Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap Daniel Vetter <daniel@ffwll.ch> - 2015-10-13 10:30 +0200
          Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-13 18:30 +0200
            Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap Daniel Vetter <daniel@ffwll.ch> - 2015-10-14 09:40 +0200
  [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
    Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Joerg Roedel <jroedel@suse.de> - 2015-10-13 00:00 +0200
      Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-13 00:10 +0200
        Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-13 00:30 +0200
          Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Joerg Roedel <jroedel@suse.de> - 2015-10-14 15:30 +0200
  [PATCH 17/20] arch: kill ioremap_cached() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
    Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris <computersforpeace@gmail.com> - 2015-10-12 20:00 +0200
      Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-12 22:40 +0200
      Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris <computersforpeace@gmail.com> - 2015-10-12 22:40 +0200
  [PATCH 03/20] ia64: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 19/20] arch: remove ioremap_cache, replace with arch_memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 01/20] x86: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 04/20] sh: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 08/20] gma500: switch from acpi_os_ioremap to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 12/20] memconsole: fix __iomem mishandling,  switch to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 05/20] m68k: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 07/20] x86: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 15/20] sfi: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 02/20] arm: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 06/20] arm: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 18/20] arch: kill ioremap_fullcache() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 10/20] acpi: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200

csiph-web