Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap
Date	2015-10-13 00:30 +0200
Message-ID	<qiTLs-45V-27@gated-at.bofh.it> (permalink)
References	<qhOkN-73l-3@gated-at.bofh.it> <qhOkO-73l-15@gated-at.bofh.it> <qiTiq-3jf-9@gated-at.bofh.it> <qiTs5-3JD-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 12, 2015 at 3:05 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, Oct 12, 2015 at 2:58 PM, Joerg Roedel <jroedel@suse.de> wrote:
>> Hi Dan,
>>
>> On Fri, Oct 09, 2015 at 06:16:46PM -0400, Dan Williams wrote:
>>> In preparation for deprecating ioremap_cache() convert its usage in
>>> intel-iommu to memremap.  This also eliminates the mishandling of the
>>> __iomem annotation in the implementation.
>>
>> I appreciate the change, but in the cover letter you write the API is
>> only implemented for x86 so far? The VT-d driver is also used on ia64,
>> will it still work there with this patch?
>>
>>
>
> I did convert ia64 in the series [1]  but you're right this patch
> can't go in independently of that conversion.  If you ack this one
> I'll carry them in order.
>
> [1]: https://lkml.org/lkml/2015/10/9/702

Ah sorry, got ahead of myself ;-p.  You can safely take this patch
through your tree.  The ia64 patch can happen asynchronously because
kernel/memremap.c has:

__weak void *arch_memremap(resource_size_t offset, size_t size,
unsigned long flags)

...as a temporary fallback until the conversion is complete.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 00/20] tree-wide convert to memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 09/20] i915: switch from acpi_os_ioremap to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
    Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap Daniel Vetter <daniel@ffwll.ch> - 2015-10-12 09:00 +0200
      Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap "Williams, Dan J" <dan.j.williams@intel.com> - 2015-10-12 23:20 +0200
        Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap Daniel Vetter <daniel@ffwll.ch> - 2015-10-13 10:30 +0200
          Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-13 18:30 +0200
            Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap Daniel Vetter <daniel@ffwll.ch> - 2015-10-14 09:40 +0200
  [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
    Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Joerg Roedel <jroedel@suse.de> - 2015-10-13 00:00 +0200
      Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-13 00:10 +0200
        Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-13 00:30 +0200
          Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Joerg Roedel <jroedel@suse.de> - 2015-10-14 15:30 +0200
  [PATCH 17/20] arch: kill ioremap_cached() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
    Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris <computersforpeace@gmail.com> - 2015-10-12 20:00 +0200
      Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-12 22:40 +0200
      Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris <computersforpeace@gmail.com> - 2015-10-12 22:40 +0200
  [PATCH 03/20] ia64: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 19/20] arch: remove ioremap_cache, replace with arch_memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 01/20] x86: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 04/20] sh: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 08/20] gma500: switch from acpi_os_ioremap to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 12/20] memconsole: fix __iomem mishandling,  switch to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 05/20] m68k: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 07/20] x86: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 15/20] sfi: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 02/20] arm: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 06/20] arm: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 18/20] arch: kill ioremap_fullcache() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 10/20] acpi: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200

csiph-web