Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244417

Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to memremap

Show all headers | View raw

On Fri, Oct 09, 2015 at 06:16:25PM -0400, Dan Williams wrote:
> i915 expects the OpRegion to be cached (i.e. not __iomem), so explicitly
> map it with memremap rather than the implied cache setting of
> acpi_os_ioremap().
> 
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Assuming you've run sparse over this to make sure you've caught them all,
and with the nit below addressed this is

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Feel free to pull v2 into whatever tree you think it's suitable for (but
you can also resend and I'll pick it up).

> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index e2ab3f6ed022..c8444d5f549f 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -387,7 +387,7 @@ intel_panel_detect(struct drm_device *dev)
>  
>  	/* Assume that the BIOS does not lie through the OpRegion... */
>  	if (!i915.panel_ignore_lid && dev_priv->opregion.lid_state) {
> -		return ioread32(dev_priv->opregion.lid_state) & 0x1 ?
> +		return *(dev_priv->opregion.lid_state) & 0x1 ?

() are redundant now here.
-Daniel

>  			connector_status_connected :
>  			connector_status_disconnected;
>  	}
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/20] tree-wide convert to memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 09/20] i915: switch from acpi_os_ioremap to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
    Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap Daniel Vetter <daniel@ffwll.ch> - 2015-10-12 09:00 +0200
      Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap "Williams, Dan J" <dan.j.williams@intel.com> - 2015-10-12 23:20 +0200
        Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap Daniel Vetter <daniel@ffwll.ch> - 2015-10-13 10:30 +0200
          Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-13 18:30 +0200
            Re: [Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to  memremap Daniel Vetter <daniel@ffwll.ch> - 2015-10-14 09:40 +0200
  [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
    Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Joerg Roedel <jroedel@suse.de> - 2015-10-13 00:00 +0200
      Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-13 00:10 +0200
        Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-13 00:30 +0200
          Re: [PATCH 13/20] intel-iommu: switch from ioremap_cache to memremap Joerg Roedel <jroedel@suse.de> - 2015-10-14 15:30 +0200
  [PATCH 17/20] arch: kill ioremap_cached() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
    Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris <computersforpeace@gmail.com> - 2015-10-12 20:00 +0200
      Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-12 22:40 +0200
      Re: [PATCH 14/20] pxa2xx-flash: switch from ioremap_cache to memremap Brian Norris <computersforpeace@gmail.com> - 2015-10-12 22:40 +0200
  [PATCH 03/20] ia64: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 19/20] arch: remove ioremap_cache, replace with arch_memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 01/20] x86: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 04/20] sh: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 08/20] gma500: switch from acpi_os_ioremap to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 12/20] memconsole: fix __iomem mishandling,  switch to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 05/20] m68k: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 07/20] x86: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 15/20] sfi: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 02/20] arm: introduce arch_memremap() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 06/20] arm: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 18/20] arch: kill ioremap_fullcache() Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 10/20] acpi: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200
  [PATCH 11/20] sound, skylake: switch from ioremap_cache to memremap Dan Williams <dan.j.williams@intel.com> - 2015-10-10 00:30 +0200

csiph-web