Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent
Date	Fri, 09 Oct 2015 13:40:03 +0200
Message-ID	<qhEbN-R9-31@gated-at.bofh.it> (permalink)
References	<qhjAm-4X0-7@gated-at.bofh.it> <qhjAn-4X0-35@gated-at.bofh.it> <qhl98-7i7-5@gated-at.bofh.it>
X-Original-To	Heiko Stuebner <heiko@sntech.de>
Organization	Collabora Ltd.
Content-Type	text/plain; charset="UTF-8"
Content-Transfer-Encoding	8BIT
X-Mailer	Evolution 3.16.5-1
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
X-Original-Cc	linux-rockchip@lists.infradead.org, Jaroslav Kysela <perex@perex.cz>, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org, Kumar Gala <galak@codeaurora.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@arm.linux.org.uk>, linux-arm-kernel@lists.infradead.org, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, linux-clk@vger.kernel.org
X-Original-Date	Fri, 09 Oct 2015 13:35:55 +0200
X-Original-Message-ID	<1444390555.9895.271.camel@collabora.co.uk>
X-Original-References	<1444311079-2892-1-git-send-email-sjoerd.simons@collabora.co.uk> <1444311079-2892-6-git-send-email-sjoerd.simons@collabora.co.uk> <11755202.f1LLWMlYi0@phil>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1243280

Show key headers only | View raw

Hey Heiko,

On Thu, 2015-10-08 at 17:10 +0200, Heiko Stuebner wrote:
> Am Donnerstag, 8. Oktober 2015, 15:31:16 schrieb Sjoerd Simons:
> > The clock branches leading to sclk_spdif and sclk_spdif_8ch on
> > RK3288
> > SoCs only feed those clocks, allow those clocks to change their
> > parents
> > all the way up the hierarchy.
> > 
> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> 
> Just as comment, if I'm seeing that right, this patch needs "clk:
> rockchip: 
> handle mux dependency of fractional dividers" and friends [0] to
> apply and 
> also actually handle the fractional dividers correctly.
> 
> For the clock change itself:
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Oh sorry yes, i completely forgot to at that as note on this patch
(series). These are on top of your series as those are required to make
things actually work as expected. 

Which reminds me, i was wondering how to best move that forward. Could
you pick this one up to include it in the next round of your series?
(Otherwise i'm happy to rebase it once you do a v2)

> 
> Heiko
> 
> [0] http://lists.infradead.org/pipermail/linux-rockchip/2015-August/0
> 03930.html


-- 
Sjoerd Simons
Collabora Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v4 0/8] Add SPDIF support for rockchip Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver bindings Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
    Re: [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver bindings Rob Herring <robh@kernel.org> - 2015-10-08 19:00 +0200
      Re: [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver  bindings Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-09 14:00 +0200
  [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
    Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent Heiko Stuebner <heiko@sntech.de> - 2015-10-08 17:20 +0200
      Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to  change their parent Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-09 13:40 +0200
        Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent Heiko Stübner <heiko@sntech.de> - 2015-10-11 12:50 +0200
  [PATCH v4 4/8] ARM: dts: rockchip: Add SPDIF optical out on Radxa Rock Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  [PATCH v4 3/8] ARM: dts: rockchip: Add SPDIF transceiver for RK3188 Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  [PATCH v4 2/8] ASoC: rockchip: Add rockchip SPDIF transceiver driver Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  [PATCH v4 6/8] ARM: dts: rockchip: Add SPDIF transceiver for RK3288 Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  Re: [PATCH v4 0/8] Add SPDIF support for rockchip Heiko Stübner <heiko@sntech.de> - 2015-10-14 00:00 +0200

csiph-web