Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1242610

Re: [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver bindings

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver bindings
Date 2015-10-08 19:00 +0200
Message-ID <qhmHV-UH-35@gated-at.bofh.it> (permalink)
References <qhjAm-4X0-7@gated-at.bofh.it> <qhjAm-4X0-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Oct 8, 2015 at 8:31 AM, Sjoerd Simons
<sjoerd.simons@collabora.co.uk> wrote:
> Add devicetree bindings for the spdif tranceiver found on
> found on rk3066, rk3188 and rk3288 SoCs
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>
> ---
>
> Changes in v4:
> - Require rockchip,grf on RK3288 as the 8 channel solution has to be
>   selected on that SoC
> - Make the compatibility string one of a known list rather then
>   requiring a precise list of options.
> - Change the clock names to hclk and mclk instead of spdif_hclk and
>   spdif_mclk to better match the implementation and data sheets.
>
> Changes in v3: None
> Changes in v2: None
>
>  .../devicetree/bindings/sound/rockchip-spdif.txt   | 44 ++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/rockchip-spdif.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-spdif.txt b/Documentation/devicetree/bindings/sound/rockchip-spdif.txt
> new file mode 100644
> index 0000000..33dd82c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/rockchip-spdif.txt
> @@ -0,0 +1,44 @@
> +* Rockchip SPDIF transceiver
> +
> +The S/PDIF audio block is a stereo transceiver that allows the
> +processor to receive and transmit digital audio via an coaxial cable or
> +a fibre cable.
> +
> +Required properties:
> +
> +- compatible: should be one of the following:
> +   - "rockchip,rk3288-spdif", "rockchip,rk3188-spdif" or
> +     "rockchip,rk3066-spdif"
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +- interrupts: should contain the SPDIF interrupt.

> +- #address-cells: should be 1.
> +- #size-cells: should be 0.

Why do you need these? Are you going to have sub nodes?

> +- dmas: DMA specifiers for tx dma. See the DMA client binding,
> +  Documentation/devicetree/bindings/dma/dma.txt
> +- dma-names: should be "tx"
> +- clocks: a list of phandle + clock-specifier pairs, one for each entry
> +  in clock-names.
> +- clock-names: should contain following:
> +   - "hclk": clock for SPDIF controller
> +   - "mclk" : clock for SPDIF bus
> +
> +Required properties on RK3288:
> +  - rockchip,grf: the phandle of the syscon node for the general register
> +                   file (GRF)
> +
> +Example for the rk3188 SPDIF controller:
> +
> +spdif: spdif@0x1011e000 {
> +       compatible = "rockchip,rk3188-spdif", "rockchip,rk3066-spdif";
> +       reg = <0x1011e000 0x2000>;
> +       interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +       dmas = <&dmac1_s 8>;
> +       dma-names = "tx";
> +       clock-names = "hclk", "mclk";
> +       clocks = <&cru HCLK_SPDIF>, <&cru SCLK_SPDIF>;
> +       status = "disabled";
> +       #sound-dai-cells = <0>;
> +};
> --
> 2.6.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 0/8] Add SPDIF support for rockchip Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver bindings Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
    Re: [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver bindings Rob Herring <robh@kernel.org> - 2015-10-08 19:00 +0200
      Re: [PATCH v4 1/8] ASoC: dt-bindings: add rockchip tranceiver  bindings Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-09 14:00 +0200
  [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
    Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent Heiko Stuebner <heiko@sntech.de> - 2015-10-08 17:20 +0200
      Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to  change their parent Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-09 13:40 +0200
        Re: [PATCH v4 5/8] clk: rockchip: Allow the RK3288 SPDIF clocks to change their parent Heiko Stübner <heiko@sntech.de> - 2015-10-11 12:50 +0200
  [PATCH v4 4/8] ARM: dts: rockchip: Add SPDIF optical out on Radxa Rock Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  [PATCH v4 3/8] ARM: dts: rockchip: Add SPDIF transceiver for RK3188 Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  [PATCH v4 2/8] ASoC: rockchip: Add rockchip SPDIF transceiver driver Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  [PATCH v4 6/8] ARM: dts: rockchip: Add SPDIF transceiver for RK3288 Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-10-08 15:40 +0200
  Re: [PATCH v4 0/8] Add SPDIF support for rockchip Heiko Stübner <heiko@sntech.de> - 2015-10-14 00:00 +0200

csiph-web