Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1241453
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs |
| Date | 2015-10-07 14:40 +0200 |
| Message-ID | <qgWaM-4Te-53@gated-at.bofh.it> (permalink) |
| References | <qgCvo-1OO-17@gated-at.bofh.it> <qgJwR-3HK-17@gated-at.bofh.it> <qgSgO-7JK-17@gated-at.bofh.it> <qgVeF-3vT-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/07/2015 01:35 PM, Marc Gonzalez wrote:
> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator.
> Use it for clocksource, sched_clock, and delay_timer.
>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> ---
> AFAICS, clocksource_register_hz does not report failures via its
> return value (always 0) but writes warnings to stdout?
Yeah, it returns always 0. I suggest you assume it is returning an error
code, that will be safer for future changes in the framework (if any).
> Open question: can I call register_current_timer_delay,
> sched_clock_register, clocksource_register_hz in any order?
> ---
Yes, I think so. Thomas ?
[ ... ]
> +static void __init tango_clocksource_init(struct device_node *np)
> +{
> + struct clk *clk = of_clk_get(np, 0);
> + unsigned int xtal_freq = clk_get_rate(clk);
> + xtal_in_cnt = of_iomap(np, 0);
> + if (xtal_in_cnt == NULL)
> + panic("%s: of_iomap failed\n", np->full_name);
^^^^^^^^^^^
That does not comply with the Linux kernel coding style.
xtal_in_cnt = of_iomap(np, 0);
if (!xtal_in_cnt) {
pr_err("Argh!");
return;
}
clk = of_clk_get(np, 0);
if (!clk) {
pr_err("grumf!");
return;
}
freq = clk_get_rate(clk);
> +
> + delay_timer.freq = xtal_freq;
> + delay_timer.read_current_timer = read_xtal_counter;
> + register_current_timer_delay(&delay_timer);
> + sched_clock_register(read_sched_clock, 32, xtal_freq);
> + clocksource_register_hz(&tango_xtal, xtal_freq);
ret = clocksource_register_hz(&tango_xtal, xtal_freq);
if (ret) {
pr_err("oups!");
return;
}
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-06 17:40 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 01:10 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 10:30 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 11:50 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 13:20 +0200
Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 13:40 +0200
[PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 13:40 +0200
Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 14:40 +0200
Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 15:20 +0200
Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 18:10 +0200
Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Mason <slash.tmp@free.fr> - 2015-10-08 15:20 +0200
[PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 14:30 +0200
Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-09 15:30 +0200
Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 15:50 +0200
Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-09 16:30 +0200
Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Nicolas Pitre <nicolas.pitre@linaro.org> - 2015-10-09 18:40 +0200
[PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 16:40 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-09 16:50 +0200
[PATCH v5] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 17:00 +0200
Re: [PATCH v5] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-16 14:10 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Måns Rullgård <mans@mansr.com> - 2015-10-09 17:00 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 17:50 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Måns Rullgård <mans@mansr.com> - 2015-10-09 18:10 +0200
Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 18:40 +0200
csiph-web