Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243375

Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs

Show all headers | View raw

On 09/10/2015 15:24, Daniel Lezcano wrote:
> On 10/09/2015 02:13 PM, Marc Gonzalez wrote:
>> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator.
>> Use it for clocksource, sched_clock, and delay_timer.
>>
>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>> ---
>> I have a nagging feeling that the QUIT_IF macro will get this patch NAKed ;-)
>> My rationale: error-handling tends to take the focus away from the normal
>> path, and put it on the error path. Hiding the details away in a macro
>> helps to keep the error-handling noise to a minimum.
> 
> It is a right feeling :)
> 
> The Linux kernel code follows the same path all across the different 
> sub-systems. So it is not a problem to write: if (err) ..., people is 
> used to read such code and by introducing this macro, that makes the 
> code less readable for them.
> 
> Moreover, the way you wrote the macro is strongly discouraged in the 
> CodingStyle document because there is a 'return' inside.

New patch coming right up.

On a tangential subject, it would seem that platforms with verbose logs
at init might benefit from marking as __initconst strings used in __init
functions.

I discussed this some time ago:
https://lkml.org/lkml/2015/3/25/688

which pointed to an earlier discussion:
https://lkml.org/lkml/2014/8/21/255
https://lkml.org/lkml/2014/6/22/149

Regards.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-06 17:40 +0200
  Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 01:10 +0200
    Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 10:30 +0200
      Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 11:50 +0200
        Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 13:20 +0200
          Re: [PATCH v1] clocksource: Sigma Designs Tango 27 MHz xtal Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 13:40 +0200
      [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for Tango  SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 13:40 +0200
        Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 14:40 +0200
          Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-07 15:20 +0200
            Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 18:10 +0200
              Re: [PATCH v2] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Mason <slash.tmp@free.fr> - 2015-10-08 15:20 +0200
                [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for Tango  SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 14:30 +0200
                Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-09 15:30 +0200
                Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 15:50 +0200
                Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-09 16:30 +0200
                Re: [PATCH v3] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Nicolas Pitre <nicolas.pitre@linaro.org> - 2015-10-09 18:40 +0200
                [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango  SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 16:40 +0200
                Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-09 16:50 +0200
                [PATCH v5] clocksource/drivers/tango_xtal: Add new timer for Tango  SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 17:00 +0200
                Re: [PATCH v5] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-16 14:10 +0200
                Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Måns Rullgård <mans@mansr.com> - 2015-10-09 17:00 +0200
                Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 17:50 +0200
                Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs Måns Rullgård <mans@mansr.com> - 2015-10-09 18:10 +0200
                Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for  Tango SoCs Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-10-09 18:40 +0200

csiph-web