Re: [PATCH v2] scsi: ufs: add ioctl interface for query request

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] scsi: ufs: add ioctl interface for query request
Date	2015-10-07 14:40 +0200
Message-ID	<qgWaM-4Te-49@gated-at.bofh.it> (permalink)
References	<qgRNL-6WR-1@gated-at.bofh.it> <qgS78-7ys-7@gated-at.bofh.it> <qgW14-4HJ-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 07 October 2015 12:27:54 ygardi@codeaurora.org wrote:
> 
> >> +
> >> +/*
> >> + *  IOCTL opcode for ufs queries has the following opcode after
> >> + *  SCSI_IOCTL_GET_PCI
> >> + */
> >> +#define UFS_IOCTL_QUERY                     0x5388
> >
> > Use _IOWR() to define that number with the correct argument length
> 
> i'd rather leave it as is, to be compatible with the SCSI_IOCTL
> opcodes that are defined in scsi_ioctl.h

Do you mean you require this code to work on SunOS? ;-)

If not, better use the normal conventions that Linux and BSD have for
new ioctls.

Note that the 0x53xx ioctl command numbers are also used by
include/uapi/linux/cdrom.h, this one would be right in the middle
of that.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] scsi: ufs: add ioctl interface for query request Yaniv Gardi <ygardi@codeaurora.org> - 2015-10-07 10:00 +0200
  Re: [PATCH v2] scsi: ufs: add ioctl interface for query request Arnd Bergmann <arnd@arndb.de> - 2015-10-07 10:20 +0200
    Re: [PATCH v2] scsi: ufs: add ioctl interface for query request ygardi@codeaurora.org - 2015-10-07 14:30 +0200
      Re: [PATCH v2] scsi: ufs: add ioctl interface for query request Arnd Bergmann <arnd@arndb.de> - 2015-10-07 14:40 +0200

csiph-web