Re: [PATCH] kselftest: replace $(RM) with rm -f command

From	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kselftest: replace $(RM) with rm -f command
Date	2015-10-03 16:20 +0200
Message-ID	<qfvPk-4dk-9@gated-at.bofh.it> (permalink)
References	<qcDq1-5In-11@gated-at.bofh.it> <qdwcN-rx-1@gated-at.bofh.it> <qdx8R-1Mj-5@gated-at.bofh.it> <qfmM1-86s-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

----- On Oct 3, 2015, at 12:38 AM, dvhart dvhart@infradead.org wrote:

> On Mon, Sep 28, 2015 at 03:16:53AM +0000, Mathieu Desnoyers wrote:
>> ----- On Sep 27, 2015, at 10:10 PM, Wang Long long.wanglong@huawei.com wrote:
>> 
>> > Some test's Makefile using "$(RM)" while the other's
>> > using "rm -f". It is better to use one of them in all
>> > tests.
>> 
>> I agree that this disparity appears to be unwanted. We
>> should settle on one or the other.
>> 
>> > 
>> > "rm -f" is better, because it is less magic, and everyone
>> > konws what is does.
>> 
>> "$(RM)" is clearly defined as a Makefile implicit variable
>> which defaults to "rm -f".
>> Ref. https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html
>> 
>> Leaving it as a variable is more flexible because then the
>> default behavior can be overridden if need be, which is
>> not the case of a hardcoded "rm -f".
>> 
>> Following your line of argumentation, we should then
>> invoke "gcc" directly in every Makefile because it is
>> less magic than "$(CC)". This makes no sense.
> 
> I don't think they can be compared so simply. Specifying a compiler is a common
> use case. Customizing the rm command is not, in my experience anyway, and like
> Michael, I would definately have to look up what RM means.
> 
> That said, I care more about consistency than which is used. Both are valid, but
> $(RM), while more flexible, will cost more people time to look up what it does
> as it isn't commonly used than any benefit we're likely to see from its use.
> 
> Meh. :-)

An example is "grm" when you install the opencsw repository
packages on Solaris. In the unlikely example where someone
would have a Solaris machine to build Linux, overriding
various command names, including "rm", can be useful. This
is just one example, there are probably others.

Thanks,

Mathieu

> 
> --
> Darren Hart
> Intel Open Source Technology Center

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] kselftest: using built-in rule when delete file Wang Long <long.wanglong@huawei.com> - 2015-09-23 11:50 +0200
  Re: [PATCH] kselftest: using built-in rule when delete file Michael Ellerman <mpe@ellerman.id.au> - 2015-09-24 03:50 +0200
    Re: [PATCH] kselftest: using built-in rule when delete file Michael Ellerman <mpe@ellerman.id.au> - 2015-09-24 04:10 +0200
      Re: [PATCH] kselftest: using built-in rule when delete file Darren Hart <dvhart@infradead.org> - 2015-09-25 17:50 +0200
        Re: [PATCH] kselftest: using built-in rule when delete file "long.wanglong" <long.wanglong@huawei.com> - 2015-09-28 04:10 +0200
        [PATCH] kselftest: replace $(RM) with rm -f command Wang Long <long.wanglong@huawei.com> - 2015-09-28 04:20 +0200
          Re: [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-09-28 05:20 +0200
            Re: [PATCH] kselftest: replace $(RM) with rm -f command Cam Hutchison <camh@xdna.net> - 2015-09-28 07:20 +0200
            Re: [PATCH] kselftest: replace $(RM) with rm -f command Michael Ellerman <mpe@ellerman.id.au> - 2015-09-29 12:00 +0200
              [PATCH] kselftest: replace rm -f command with $(RM) Wang Long <long.wanglong@huawei.com> - 2015-09-29 13:30 +0200
              Re: [PATCH] kselftest: replace $(RM) with rm -f command Kees Cook <keescook@chromium.org> - 2015-09-29 19:50 +0200
            Re: [PATCH] kselftest: replace $(RM) with rm -f command Darren Hart <dvhart@infradead.org> - 2015-10-03 06:40 +0200
              Re: [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-03 16:20 +0200
                Re: [PATCH] kselftest: replace $(RM) with rm -f command Josh Triplett <josh@joshtriplett.org> - 2015-10-03 20:00 +0200
                Re: [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-03 20:10 +0200
          Re: [PATCH] kselftest: replace $(RM) with rm -f command Yuan Sun <sunyuan3@huawei.com> - 2015-09-28 09:40 +0200
    Re: [PATCH] kselftest: using built-in rule when delete file "long.wanglong" <long.wanglong@huawei.com> - 2015-09-24 04:10 +0200

csiph-web