Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1233816

Re: [PATCH] kselftest: using built-in rule when delete file

Show all headers | View raw

On 2015/9/25 23:44, Darren Hart wrote:
> On Thu, Sep 24, 2015 at 12:07:47PM +1000, Michael Ellerman wrote:
>> On Thu, 2015-09-24 at 10:05 +0800, long.wanglong wrote:
>>> On 2015/9/24 9:46, Michael Ellerman wrote:
>>>> On Wed, 2015-09-23 at 09:40 +0000, Wang Long wrote:
>>>>> Use make's built-in rules to when delete a file
>>>>> or delete files.
>>>>
>>>> It's not a built-in rule, it's a variable.
>>>
>>> Sorry，I did not describe clearly. It is a variable used as
>>> name of program in built-in rules.
>>>
>>>> Personally I think using rm directly is clearer, but I guess this is fine. Do
>>>> you actually want to override $RM ?
>>>
>>> So far, I do not want to override $(RM). But I found that some test's Makefile
>>> using *$(RM)* while the other's using *rm -f*, I think it is better to use one
>>> of them in all unit tests.
> 
> Agreed, consistency is good.
> 
>>>
>>> Do you think which one is better?
>>
>> I prefer just using rm -f, because it's less magic, everyone knows what it does.
>>
> 
> Also agreed, it's explicit and perfectly functional.
> 
Ok, thanks, I will send another patch to replace $(RM) with "rm -f".

Best Regards
Wang Long

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] kselftest: using built-in rule when delete file Wang Long <long.wanglong@huawei.com> - 2015-09-23 11:50 +0200
  Re: [PATCH] kselftest: using built-in rule when delete file Michael Ellerman <mpe@ellerman.id.au> - 2015-09-24 03:50 +0200
    Re: [PATCH] kselftest: using built-in rule when delete file Michael Ellerman <mpe@ellerman.id.au> - 2015-09-24 04:10 +0200
      Re: [PATCH] kselftest: using built-in rule when delete file Darren Hart <dvhart@infradead.org> - 2015-09-25 17:50 +0200
        Re: [PATCH] kselftest: using built-in rule when delete file "long.wanglong" <long.wanglong@huawei.com> - 2015-09-28 04:10 +0200
        [PATCH] kselftest: replace $(RM) with rm -f command Wang Long <long.wanglong@huawei.com> - 2015-09-28 04:20 +0200
          Re: [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-09-28 05:20 +0200
            Re: [PATCH] kselftest: replace $(RM) with rm -f command Cam Hutchison <camh@xdna.net> - 2015-09-28 07:20 +0200
            Re: [PATCH] kselftest: replace $(RM) with rm -f command Michael Ellerman <mpe@ellerman.id.au> - 2015-09-29 12:00 +0200
              [PATCH] kselftest: replace rm -f command with $(RM) Wang Long <long.wanglong@huawei.com> - 2015-09-29 13:30 +0200
              Re: [PATCH] kselftest: replace $(RM) with rm -f command Kees Cook <keescook@chromium.org> - 2015-09-29 19:50 +0200
            Re: [PATCH] kselftest: replace $(RM) with rm -f command Darren Hart <dvhart@infradead.org> - 2015-10-03 06:40 +0200
              Re: [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-03 16:20 +0200
                Re: [PATCH] kselftest: replace $(RM) with rm -f command Josh Triplett <josh@joshtriplett.org> - 2015-10-03 20:00 +0200
                Re: [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-03 20:10 +0200
          Re: [PATCH] kselftest: replace $(RM) with rm -f command Yuan Sun <sunyuan3@huawei.com> - 2015-09-28 09:40 +0200
    Re: [PATCH] kselftest: using built-in rule when delete file "long.wanglong" <long.wanglong@huawei.com> - 2015-09-24 04:10 +0200

csiph-web