Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1233817
| From | Wang Long <long.wanglong@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] kselftest: replace $(RM) with rm -f command |
| Date | 2015-09-28 04:20 +0200 |
| Message-ID | <qdwcN-rx-1@gated-at.bofh.it> (permalink) |
| References | <qcDq1-5In-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Some test's Makefile using "$(RM)" while the other's using "rm -f". It is better to use one of them in all tests. "rm -f" is better, because it is less magic, and everyone konws what is does. Signed-off-by: Wang Long <long.wanglong@huawei.com> --- tools/testing/selftests/capabilities/Makefile | 2 +- tools/testing/selftests/kcmp/Makefile | 2 +- tools/testing/selftests/membarrier/Makefile | 2 +- tools/testing/selftests/memfd/Makefile | 2 +- tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/seccomp/Makefile | 2 +- tools/testing/selftests/size/Makefile | 2 +- tools/testing/selftests/vm/Makefile | 2 +- tools/testing/selftests/x86/Makefile | 2 +- tools/testing/selftests/zram/Makefile | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/capabilities/Makefile b/tools/testing/selftests/capabilities/Makefile index 8c8f0c1..dcc1972 100644 --- a/tools/testing/selftests/capabilities/Makefile +++ b/tools/testing/selftests/capabilities/Makefile @@ -12,7 +12,7 @@ CFLAGS := -O2 -g -std=gnu99 -Wall -lcap-ng all: $(TARGETS) clean: - $(RM) $(TARGETS) + rm -f $(TARGETS) $(TARGETS): %: %.c $(CC) -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile index 2ae7450..2deaee0 100644 --- a/tools/testing/selftests/kcmp/Makefile +++ b/tools/testing/selftests/kcmp/Makefile @@ -7,4 +7,4 @@ TEST_PROGS := kcmp_test include ../lib.mk clean: - $(RM) kcmp_test kcmp-test-file + rn -f kcmp_test kcmp-test-file diff --git a/tools/testing/selftests/membarrier/Makefile b/tools/testing/selftests/membarrier/Makefile index a1a9708..f23fc58 100644 --- a/tools/testing/selftests/membarrier/Makefile +++ b/tools/testing/selftests/membarrier/Makefile @@ -7,4 +7,4 @@ all: $(TEST_PROGS) include ../lib.mk clean: - $(RM) $(TEST_PROGS) + rm -f $(TEST_PROGS) diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile index 3e7eb79..068fa93 100644 --- a/tools/testing/selftests/memfd/Makefile +++ b/tools/testing/selftests/memfd/Makefile @@ -19,4 +19,4 @@ run_fuse: build_fuse @./run_fuse_test.sh || echo "fuse_test: [FAIL]" clean: - $(RM) memfd_test fuse_test + rm -f memfd_test fuse_test diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index fac4782..ec7eaa4 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -16,4 +16,4 @@ TEST_FILES := $(NET_PROGS) include ../lib.mk clean: - $(RM) $(NET_PROGS) + rm -f $(NET_PROGS) diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile index 8401e87..c16072a 100644 --- a/tools/testing/selftests/seccomp/Makefile +++ b/tools/testing/selftests/seccomp/Makefile @@ -7,4 +7,4 @@ all: $(TEST_PROGS) include ../lib.mk clean: - $(RM) $(TEST_PROGS) + rm -f $(TEST_PROGS) diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile index bbd0b53..cefe914 100644 --- a/tools/testing/selftests/size/Makefile +++ b/tools/testing/selftests/size/Makefile @@ -8,4 +8,4 @@ TEST_PROGS := get_size include ../lib.mk clean: - $(RM) get_size + rm -f get_size diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index 3c53cac..26663c7 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -24,4 +24,4 @@ TEST_FILES := $(BINARIES) include ../lib.mk clean: - $(RM) $(BINARIES) + rm -f $(BINARIES) diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile index 29089b2..48b2406 100644 --- a/tools/testing/selftests/x86/Makefile +++ b/tools/testing/selftests/x86/Makefile @@ -32,7 +32,7 @@ all_32: $(BINARIES_32) all_64: $(BINARIES_64) clean: - $(RM) $(BINARIES_32) $(BINARIES_64) + rm -f $(BINARIES_32) $(BINARIES_64) $(TARGETS_C_32BIT_ALL:%=%_32): %_32: %.c $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl diff --git a/tools/testing/selftests/zram/Makefile b/tools/testing/selftests/zram/Makefile index 29d8034..e1591c8 100644 --- a/tools/testing/selftests/zram/Makefile +++ b/tools/testing/selftests/zram/Makefile @@ -6,4 +6,4 @@ TEST_FILES := zram01.sh zram02.sh zram_lib.sh include ../lib.mk clean: - $(RM) err.log + rm -f err.log -- 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] kselftest: using built-in rule when delete file Wang Long <long.wanglong@huawei.com> - 2015-09-23 11:50 +0200
Re: [PATCH] kselftest: using built-in rule when delete file Michael Ellerman <mpe@ellerman.id.au> - 2015-09-24 03:50 +0200
Re: [PATCH] kselftest: using built-in rule when delete file Michael Ellerman <mpe@ellerman.id.au> - 2015-09-24 04:10 +0200
Re: [PATCH] kselftest: using built-in rule when delete file Darren Hart <dvhart@infradead.org> - 2015-09-25 17:50 +0200
Re: [PATCH] kselftest: using built-in rule when delete file "long.wanglong" <long.wanglong@huawei.com> - 2015-09-28 04:10 +0200
[PATCH] kselftest: replace $(RM) with rm -f command Wang Long <long.wanglong@huawei.com> - 2015-09-28 04:20 +0200
Re: [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-09-28 05:20 +0200
Re: [PATCH] kselftest: replace $(RM) with rm -f command Cam Hutchison <camh@xdna.net> - 2015-09-28 07:20 +0200
Re: [PATCH] kselftest: replace $(RM) with rm -f command Michael Ellerman <mpe@ellerman.id.au> - 2015-09-29 12:00 +0200
[PATCH] kselftest: replace rm -f command with $(RM) Wang Long <long.wanglong@huawei.com> - 2015-09-29 13:30 +0200
Re: [PATCH] kselftest: replace $(RM) with rm -f command Kees Cook <keescook@chromium.org> - 2015-09-29 19:50 +0200
Re: [PATCH] kselftest: replace $(RM) with rm -f command Darren Hart <dvhart@infradead.org> - 2015-10-03 06:40 +0200
Re: [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-03 16:20 +0200
Re: [PATCH] kselftest: replace $(RM) with rm -f command Josh Triplett <josh@joshtriplett.org> - 2015-10-03 20:00 +0200
Re: [PATCH] kselftest: replace $(RM) with rm -f command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-10-03 20:10 +0200
Re: [PATCH] kselftest: replace $(RM) with rm -f command Yuan Sun <sunyuan3@huawei.com> - 2015-09-28 09:40 +0200
Re: [PATCH] kselftest: using built-in rule when delete file "long.wanglong" <long.wanglong@huawei.com> - 2015-09-24 04:10 +0200
csiph-web