Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1239088

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases
Date 2015-10-04 12:20 +0200
Message-ID <qfOyB-5PS-1@gated-at.bofh.it> (permalink)
References <qfriF-684-9@gated-at.bofh.it> <qfriG-684-13@gated-at.bofh.it> <qfN9x-3HH-19@gated-at.bofh.it> <qfNCx-4vs-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Oct 04, 2015 at 12:16:31PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote:
> > Aren't you now leaking memory as you aren't freeing pstrMessage and the
> > buffer on the "normal" return path?
> 
> It's supposed to.  It's a bug fix.  I explained to him in the first
> version that his changelog sucks.

Ok, well, it still sucks :)

And it's out of my queue, so I'll wait for the next spin of this
series...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section Chandra S Gorentla <csgorentla@gmail.com> - 2015-10-03 11:30 +0200
  [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases Chandra S Gorentla <csgorentla@gmail.com> - 2015-10-03 11:30 +0200
    Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for  error cases Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 10:50 +0200
      Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for  error cases Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-04 11:20 +0200
        Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for  error cases Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 12:20 +0200
      Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for  error cases Chandra Gorentla <csgorentla@gmail.com> - 2015-10-04 12:30 +0200
        Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error  cases Tony Cho <tony.cho@atmel.com> - 2015-10-05 05:30 +0200
  Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the  start of critical section Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 10:50 +0200
    Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the  start of critical section Chandra Gorentla <csgorentla@gmail.com> - 2015-10-04 12:10 +0200
      Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the  start of critical section Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 12:30 +0200
    Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the  start of critical section Tony Cho <tony.cho@atmel.com> - 2015-10-05 05:30 +0200

csiph-web