Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238787

[PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

Show all headers | View raw

The spin_lock_irqsave is moved to just beginning of critical section.
This change moves a couple of return statements out of the lock.

Signed-off-by: Chandra S Gorentla <csgorentla@gmail.com>
---
 drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c
index d5ebd6d..284a3f5 100644
--- a/drivers/staging/wilc1000/wilc_msgqueue.c
+++ b/drivers/staging/wilc1000/wilc_msgqueue.c
@@ -72,8 +72,6 @@ int wilc_mq_send(WILC_MsgQueueHandle *pHandle,
 		goto ERRORHANDLER;
 	}
 
-	spin_lock_irqsave(&pHandle->strCriticalSection, flags);
-
 	/* construct a new message */
 	pstrMessage = kmalloc(sizeof(Message), GFP_ATOMIC);
 	if (!pstrMessage)
@@ -87,6 +85,8 @@ int wilc_mq_send(WILC_MsgQueueHandle *pHandle,
 	}
 	memcpy(pstrMessage->pvBuffer, pvSendBuffer, u32SendBufferSize);
 
+	spin_lock_irqsave(&pHandle->strCriticalSection, flags);
+
 	/* add it to the message queue */
 	if (!pHandle->pstrMessageList) {
 		pHandle->pstrMessageList  = pstrMessage;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section Chandra S Gorentla <csgorentla@gmail.com> - 2015-10-03 11:30 +0200
  [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases Chandra S Gorentla <csgorentla@gmail.com> - 2015-10-03 11:30 +0200
    Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for  error cases Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 10:50 +0200
      Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for  error cases Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-04 11:20 +0200
        Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for  error cases Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 12:20 +0200
      Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for  error cases Chandra Gorentla <csgorentla@gmail.com> - 2015-10-04 12:30 +0200
        Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error  cases Tony Cho <tony.cho@atmel.com> - 2015-10-05 05:30 +0200
  Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the  start of critical section Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 10:50 +0200
    Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the  start of critical section Chandra Gorentla <csgorentla@gmail.com> - 2015-10-04 12:10 +0200
      Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the  start of critical section Greg KH <gregkh@linuxfoundation.org> - 2015-10-04 12:30 +0200
    Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the  start of critical section Tony Cho <tony.cho@atmel.com> - 2015-10-05 05:30 +0200

csiph-web