Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1235758

Re: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable

Show all headers | View raw

On Wed, 30 Sep 2015 08:10:04 +0300 Alexandru Moise <00moses.alexander00@gmail.com> wrote:

> > > --- a/mm/vmscan.c
> > > +++ b/mm/vmscan.c
> > > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
> > >  
> > >  static unsigned long zone_reclaimable_pages(struct zone *zone)
> > >  {
> > > -	int nr;
> > > +	unsigned long nr;
> > >  
> > >  	nr = zone_page_state(zone, NR_ACTIVE_FILE) +
> > >  	     zone_page_state(zone, NR_INACTIVE_FILE);
> > 
> > OK.
> > 
> 
> Are you sure? Mel Gorman raised the following issue on patch 1/2:
> 
> https://lkml.org/lkml/2015/9/29/253

__zone_watermark_ok() is very different from zone_reclaimable_pages().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-27 20:10 +0200
  Re: [PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Andrew Morton <akpm@linux-foundation.org> - 2015-09-30 01:10 +0200
    Re: [PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-30 07:20 +0200
      Re: [PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Andrew Morton <akpm@linux-foundation.org> - 2015-09-30 07:30 +0200
        Re: [PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-30 07:40 +0200

csiph-web