Re: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable

From	Alexandru Moise <00moses.alexander00@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable
Date	2015-09-30 07:40 +0200
Message-ID	<qeiht-44N-11@gated-at.bofh.it> (permalink)
References	<qdoyC-6jq-1@gated-at.bofh.it> <qecc2-3RU-13@gated-at.bofh.it> <qehY5-3It-5@gated-at.bofh.it> <qei7L-3TG-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 29, 2015 at 10:28:57PM -0700, Andrew Morton wrote:
> On Wed, 30 Sep 2015 08:10:04 +0300 Alexandru Moise <00moses.alexander00@gmail.com> wrote:
> 
> > > > --- a/mm/vmscan.c
> > > > +++ b/mm/vmscan.c
> > > > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
> > > >  
> > > >  static unsigned long zone_reclaimable_pages(struct zone *zone)
> > > >  {
> > > > -	int nr;
> > > > +	unsigned long nr;
> > > >  
> > > >  	nr = zone_page_state(zone, NR_ACTIVE_FILE) +
> > > >  	     zone_page_state(zone, NR_INACTIVE_FILE);
> > > 
> > > OK.
> > > 
> > 
> > Are you sure? Mel Gorman raised the following issue on patch 1/2:
> > 
> > https://lkml.org/lkml/2015/9/29/253
> 
> __zone_watermark_ok() is very different from zone_reclaimable_pages().

Alright, in time I will gain a better understanding of this.
Thanks again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-27 20:10 +0200
  Re: [PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Andrew Morton <akpm@linux-foundation.org> - 2015-09-30 01:10 +0200
    Re: [PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-30 07:20 +0200
      Re: [PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Andrew Morton <akpm@linux-foundation.org> - 2015-09-30 07:30 +0200
        Re: [PATCH 2/2] mm: fix declarations of nr, delta and  nr_pagecache_reclaimable Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-30 07:40 +0200

csiph-web