Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1237775
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Felipe Balbi <balbi@ti.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c |
| Date | Fri, 02 Oct 2015 00:10:02 +0200 |
| Message-ID | <qeUd4-Rt-29@gated-at.bofh.it> (permalink) |
| References | <qb6mt-3FW-7@gated-at.bofh.it> <qb6mu-3FW-23@gated-at.bofh.it> <qeOr0-Eb-3@gated-at.bofh.it> <qeTh0-7Uy-17@gated-at.bofh.it> |
| X-Original-To | John Youn <John.Youn@synopsys.com> |
| Reply-To | <balbi@ti.com> |
| MIME-Version | 1.0 |
| Content-Type | multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dc+cDN39EJAMEtIO" |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 69 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | "balbi@ti.com" <balbi@ti.com>, Marek Szyprowski <m.szyprowski@samsung.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, Robert Baldyga <r.baldyga@samsung.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
| X-Original-Date | Thu, 1 Oct 2015 17:03:55 -0500 |
| X-Original-Message-ID | <20151001220355.GB32355@saruman.tx.rr.com> |
| X-Original-References | <1442830572-6765-1-git-send-email-m.szyprowski@samsung.com> <1442830572-6765-5-git-send-email-m.szyprowski@samsung.com> <20151001155018.GC4469@saruman.tx.rr.com> <2B3535C5ECE8B5419E3ECBE30077290901DC383B31@US01WEMBX2.internal.synopsys.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1237775 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
On Thu, Oct 01, 2015 at 09:04:59PM +0000, John Youn wrote: > On 10/1/2015 8:50 AM, Felipe Balbi wrote: > > On Mon, Sep 21, 2015 at 12:16:12PM +0200, Marek Szyprowski wrote: > >> DWC2 module on some platforms needs three additional hardware > >> resources: phy controller, clock and power supply. All of them must be > >> enabled/activated to properly initialize and operate. This was initially > >> handled in s3c-hsotg driver, which has been converted to 'gadget' part > >> of dwc2 driver. Unfortunately, not all of this code got moved to common > >> platform code, what resulted in accessing DWC2 registers without > >> enabling low-level hardware resources. This fails for example on Exynos > >> SoCs. This patch moves all the code for managing those resources to > >> common platform.c file and provides convenient wrappers for controlling > >> them. > >> > >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > > > I just caught several build errors which this patch. I hope you can > > send me a follow-up fix (which I can amend to $subject) otherwise > > I'll have to drop this series > > > > I forgot that this was initially part of a larger > patch-set. Maybe that is causing issues? If this wasn't intended > to go through Felipe's tree then my bad. > > Also, I noticed this patch causes deadlock warnings with lockdep > enabled. > > Can you look into that also while you investigate this? John, do you want me to drop the series meanwhile ? I can do that no problems. -- balbi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c Felipe Balbi <balbi@ti.com> - 2015-10-01 18:00 +0200
Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c John Youn <John.Youn@synopsys.com> - 2015-10-01 23:10 +0200
Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c Felipe Balbi <balbi@ti.com> - 2015-10-02 00:10 +0200
Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c John Youn <John.Youn@synopsys.com> - 2015-10-02 00:30 +0200
Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c Felipe Balbi <balbi@ti.com> - 2015-10-02 00:40 +0200
Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c Marek Szyprowski <m.szyprowski@samsung.com> - 2015-10-02 09:50 +0200
csiph-web