Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c
Date	2015-10-02 00:40 +0200
Message-ID	<qeUG6-1pD-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <qb6mu-3FW-23@gated-at.bofh.it> <qeOr0-Eb-3@gated-at.bofh.it> <qeTh0-7Uy-17@gated-at.bofh.it> <qeUd4-Rt-29@gated-at.bofh.it> <qeUwr-1eq-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Oct 01, 2015 at 10:21:22PM +0000, John Youn wrote:
> On 10/1/2015 3:04 PM, Felipe Balbi wrote:
> > On Thu, Oct 01, 2015 at 09:04:59PM +0000, John Youn wrote:
> >> On 10/1/2015 8:50 AM, Felipe Balbi wrote:
> >>> On Mon, Sep 21, 2015 at 12:16:12PM +0200, Marek Szyprowski wrote:
> >>>> DWC2 module on some platforms needs three additional hardware
> >>>> resources: phy controller, clock and power supply. All of them must be
> >>>> enabled/activated to properly initialize and operate. This was initially
> >>>> handled in s3c-hsotg driver, which has been converted to 'gadget' part
> >>>> of dwc2 driver. Unfortunately, not all of this code got moved to common
> >>>> platform code, what resulted in accessing DWC2 registers without
> >>>> enabling low-level hardware resources. This fails for example on Exynos
> >>>> SoCs. This patch moves all the code for managing those resources to
> >>>> common platform.c file and provides convenient wrappers for controlling
> >>>> them.
> >>>>
> >>>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> >>>
> >>> I just caught several build errors which this patch. I hope you can
> >>> send me a follow-up fix (which I can amend to $subject) otherwise
> >>> I'll have to drop this series
> >>>
> >>
> >> I forgot that this was initially part of a larger
> >> patch-set. Maybe that is causing issues? If this wasn't intended
> >> to go through Felipe's tree then my bad.
> >>
> >> Also, I noticed this patch causes deadlock warnings with lockdep
> >> enabled.
> >>
> >> Can you look into that also while you investigate this?
> > 
> > John, do you want me to drop the series meanwhile ? I can do that no problems.
> > 
> 
> You can drop this one. I think leaving in patch 1-3 is fine as
> they are small cleanup patches. Unless you or Marek prefer to
> drop all of them.

dropped this one for now. Thanks

-- 
balbi

Thread

Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c Felipe Balbi <balbi@ti.com> - 2015-10-01 18:00 +0200
  Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c John Youn <John.Youn@synopsys.com> - 2015-10-01 23:10 +0200
    Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c Felipe Balbi <balbi@ti.com> - 2015-10-02 00:10 +0200
      Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c John Youn <John.Youn@synopsys.com> - 2015-10-02 00:30 +0200
        Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c Felipe Balbi <balbi@ti.com> - 2015-10-02 00:40 +0200
        Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c Marek Szyprowski <m.szyprowski@samsung.com> - 2015-10-02 09:50 +0200

csiph-web