Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c
Date	2015-10-01 18:00 +0200
Message-ID	<qeOr0-Eb-3@gated-at.bofh.it> (permalink)
References	<qb6mt-3FW-7@gated-at.bofh.it> <qb6mu-3FW-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Sep 21, 2015 at 12:16:12PM +0200, Marek Szyprowski wrote:
> DWC2 module on some platforms needs three additional hardware
> resources: phy controller, clock and power supply. All of them must be
> enabled/activated to properly initialize and operate. This was initially
> handled in s3c-hsotg driver, which has been converted to 'gadget' part
> of dwc2 driver. Unfortunately, not all of this code got moved to common
> platform code, what resulted in accessing DWC2 registers without
> enabling low-level hardware resources. This fails for example on Exynos
> SoCs. This patch moves all the code for managing those resources to
> common platform.c file and provides convenient wrappers for controlling
> them.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

I just caught several build errors which this patch. I hope you can
send me a follow-up fix (which I can amend to $subject) otherwise
I'll have to drop this series

-- 
balbi

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c Felipe Balbi <balbi@ti.com> - 2015-10-01 18:00 +0200
  Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c John Youn <John.Youn@synopsys.com> - 2015-10-01 23:10 +0200
    Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c Felipe Balbi <balbi@ti.com> - 2015-10-02 00:10 +0200
      Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c John Youn <John.Youn@synopsys.com> - 2015-10-02 00:30 +0200
        Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c Felipe Balbi <balbi@ti.com> - 2015-10-02 00:40 +0200
        Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c Marek Szyprowski <m.szyprowski@samsung.com> - 2015-10-02 09:50 +0200

csiph-web