Re: CPU hotplug and chained interrupts on x86

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: CPU hotplug and chained interrupts on x86
Date	Thu, 01 Oct 2015 23:50:01 +0200
Message-ID	<qeTTH-eK-1@gated-at.bofh.it> (permalink)
References	<qeN1U-795-23@gated-at.bofh.it> <qeNbz-7kT-1@gated-at.bofh.it>
X-Original-To	Mika Westerberg <mika.westerberg@linux.intel.com>
User-Agent	Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score	-1.0
X-Linutronix-Spam-Level	-
X-Linutronix-Spam-Status	No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	Jiang Liu <jiang.liu@linux.intel.com>, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 1 Oct 2015 23:45:23 +0200 (CEST)
X-Original-Message-ID	<alpine.DEB.2.11.1510012343370.4500@nanos>
X-Original-References	<20151001142147.GO1551@lahna.fi.intel.com> <alpine.DEB.2.11.1510011625000.4500@nanos>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1237762

Show key headers only | View raw

On Thu, 1 Oct 2015, Thomas Gleixner wrote:
> On Thu, 1 Oct 2015, Mika Westerberg wrote:
> > Now if I plug/unplug the card I may get few interrupts to CPU0 but rest
> > of the interrupts never happen. Probably because IO-APIC forwards them
> > to the lowest priority CPU which is offline at this point.
> > 
> > There is following check in fixup_irqs():
> > 
> > 	if (!irq_has_action(irq) || irqd_is_per_cpu(data) ||
> > 	    cpumask_subset(affinity, cpu_online_mask)) {
> > 		raw_spin_unlock(&desc->lock);
> > 		continue;
> > 	}   
> > 
> > If an interrupt is requested by a driver it will force new affinity and
> > everything works fine. However if the interrupt is chained (it does not
> > have ->action) this is skipped and the current affinity remains.
> > 
> > We could detect here if the interrupt is chained but there seems to be
> > no easy way to determine it currently so we would need to add a new flag
> > to desc->status_use_accessors that gets set in __irq_do_set_handler()
> > when is_chained is 1.
> 
> Either there or in irq_data. Need to look at it in detail.

desc->status_use_accessors is the place where this wants to go.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

CPU hotplug and chained interrupts on x86 Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-01 16:30 +0200
  Re: CPU hotplug and chained interrupts on x86 Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 16:40 +0200
    Re: CPU hotplug and chained interrupts on x86 Jiang Liu <jiang.liu@linux.intel.com> - 2015-10-01 19:10 +0200
    Re: CPU hotplug and chained interrupts on x86 Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 23:50 +0200
      Re: CPU hotplug and chained interrupts on x86 Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-02 07:00 +0200

csiph-web