Re: CPU hotplug and chained interrupts on x86

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: CPU hotplug and chained interrupts on x86
Date	2015-10-02 07:00 +0200
Message-ID	<qf0BP-1uk-3@gated-at.bofh.it> (permalink)
References	<qeN1U-795-23@gated-at.bofh.it> <qeNbz-7kT-1@gated-at.bofh.it> <qeTTH-eK-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Thu, Oct 01, 2015 at 11:45:23PM +0200, Thomas Gleixner wrote:
> On Thu, 1 Oct 2015, Thomas Gleixner wrote:
> > On Thu, 1 Oct 2015, Mika Westerberg wrote:
> > > Now if I plug/unplug the card I may get few interrupts to CPU0 but rest
> > > of the interrupts never happen. Probably because IO-APIC forwards them
> > > to the lowest priority CPU which is offline at this point.
> > > 
> > > There is following check in fixup_irqs():
> > > 
> > > 	if (!irq_has_action(irq) || irqd_is_per_cpu(data) ||
> > > 	    cpumask_subset(affinity, cpu_online_mask)) {
> > > 		raw_spin_unlock(&desc->lock);
> > > 		continue;
> > > 	}   
> > > 
> > > If an interrupt is requested by a driver it will force new affinity and
> > > everything works fine. However if the interrupt is chained (it does not
> > > have ->action) this is skipped and the current affinity remains.
> > > 
> > > We could detect here if the interrupt is chained but there seems to be
> > > no easy way to determine it currently so we would need to add a new flag
> > > to desc->status_use_accessors that gets set in __irq_do_set_handler()
> > > when is_chained is 1.
> > 
> > Either there or in irq_data. Need to look at it in detail.
> 
> desc->status_use_accessors is the place where this wants to go.

Thank you.

I'll prepare a patch fixing this shortly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

CPU hotplug and chained interrupts on x86 Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-01 16:30 +0200
  Re: CPU hotplug and chained interrupts on x86 Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 16:40 +0200
    Re: CPU hotplug and chained interrupts on x86 Jiang Liu <jiang.liu@linux.intel.com> - 2015-10-01 19:10 +0200
    Re: CPU hotplug and chained interrupts on x86 Thomas Gleixner <tglx@linutronix.de> - 2015-10-01 23:50 +0200
      Re: CPU hotplug and chained interrupts on x86 Mika Westerberg <mika.westerberg@linux.intel.com> - 2015-10-02 07:00 +0200

csiph-web