Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1233668

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

Show all headers | View raw

On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote:
> On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote:
> > On 25 September 2015 at 15:19, Rafael J. Wysocki <rafael@kernel.org> wrote:
> > > So if you allow something like debugfs to update your structure, how
> > > do you make sure there is the proper locking?
> > 
> > Not really sure at all.. Isn't there some debugfs locking that will
> > jump in, to avoid updation of fields to the same device?
> 
> No, if you need any locking to access variable, you cannot use the
> simple debugfs helpers but have to provide your own functions.
> 
> > >> Anyway, that problem isn't here for sure as its between two
> > >> unsigned-longs. So, should I just move it to bool and resend ?
> > >
> > > I guess it might be more convenient to fold this into the other patch,
> > > because we seem to be splitting hairs here.
> > 
> > I can and that's what I did. But then Arnd asked me to separate it
> > out. I can fold it back if that's what you want.
> 
> It still makes sense to keep it separate I think, the patch is clearly
> different from the other parts.

I just don't see much point in going from unsigned long to u32 and then
from 32 to bool if we can go directly to bool in one go.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 18:50 +0200
  [PATCH V4 2/2] debugfs: Pass bool pointer to debugfs_create_bool() Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 18:50 +0200
  Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' Johannes Berg <johannes@sipsolutions.net> - 2015-09-25 19:50 +0200
    Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 20:50 +0200
      Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' Johannes Berg <johannes@sipsolutions.net> - 2015-09-25 20:50 +0200
        Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 21:00 +0200
          Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:00 +0200
            Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:10 +0200
              Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 22:30 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:40 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 23:50 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-26 00:30 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-26 20:50 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Arnd Bergmann <arnd@arndb.de> - 2015-09-26 21:40 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-27 15:50 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Arnd Bergmann <arnd@arndb.de> - 2015-09-28 10:30 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-28 14:40 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-26 22:00 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-27 15:50 +0200
                RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' David Laight <David.Laight@ACULAB.COM> - 2015-09-28 11:00 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-28 16:30 +0200
                RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' David Laight <David.Laight@ACULAB.COM> - 2015-09-28 17:00 +0200
                Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-28 17:20 +0200
                RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of  'global_lock' David Laight <David.Laight@ACULAB.COM> - 2015-09-28 17:40 +0200
  Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:00 +0200
    Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:00 +0200
  Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-27 16:40 +0200

csiph-web