Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1233016
| From | Johannes Berg <johannes@sipsolutions.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' |
| Date | 2015-09-25 20:50 +0200 |
| Message-ID | <qcGee-1ip-13@gated-at.bofh.it> (permalink) |
| References | <qcEm5-746-7@gated-at.bofh.it> <qcFia-8p1-5@gated-at.bofh.it> <qcGed-1ip-1@gated-at.bofh.it> <qcGee-1ip-15@gated-at.bofh.it> <qcGed-1ip-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> Rafael wrote:
> > Actually, what about adding a local u32 variable, say val, here and
> > doing
> >
> > > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32
> > > *)&first_ec->gpe))
> > > goto error;
> > > if (!debugfs_create_bool("use_global_lock", 0444,
> > > dev_dir,
> > > - (u32 *)&first_ec->global_lock))
> > > + &first_ec->global_lock))
> >
> > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > &val))
> >
> > > goto error;
> >
> > first_ec->global_lock = val;
> >
> > And then you can turn val into bool just fine without changing the
> > structure
> > definition.
Ok, then, but that means Rafael is completely wrong ...
debugfs_create_bool() takes a *pointer* and it needs to be long-lived,
it can't be on the stack. You also don't get a call when it changes.
If you cannot change the struct definition then you must implement a
debugfs file with its own read/write handlers.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 18:50 +0200
[PATCH V4 2/2] debugfs: Pass bool pointer to debugfs_create_bool() Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 18:50 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Johannes Berg <johannes@sipsolutions.net> - 2015-09-25 19:50 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 20:50 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Johannes Berg <johannes@sipsolutions.net> - 2015-09-25 20:50 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 21:00 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:00 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:10 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 22:30 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:40 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-25 23:50 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-26 00:30 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-26 20:50 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Arnd Bergmann <arnd@arndb.de> - 2015-09-26 21:40 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-27 15:50 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Arnd Bergmann <arnd@arndb.de> - 2015-09-28 10:30 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-28 14:40 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-26 22:00 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-27 15:50 +0200
RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' David Laight <David.Laight@ACULAB.COM> - 2015-09-28 11:00 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-28 16:30 +0200
RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' David Laight <David.Laight@ACULAB.COM> - 2015-09-28 17:00 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-09-28 17:20 +0200
RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' David Laight <David.Laight@ACULAB.COM> - 2015-09-28 17:40 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:00 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 22:00 +0200
Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-27 16:40 +0200
csiph-web