Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228245

Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

Show all headers | View raw

On Fri, 18 Sep 2015, Luis de Bethencourt wrote:

> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/usb/host/ehci-spear.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
> index 34e1474..3c4e525 100644
> --- a/drivers/usb/host/ehci-spear.c
> +++ b/drivers/usb/host/ehci-spear.c
> @@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
>  	{ .compatible = "st,spear600-ehci", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, spear_ehci_id_table);
>  
>  static struct platform_driver spear_ehci_hcd_driver = {
>  	.probe		= spear_ehci_hcd_drv_probe,
> 

Acked-by: Alan Stern <stern@rowland.harvard.edu>

Also for V2 of patches 3/4 and 4/4.

Alan Stern


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF  platform driver Luis de Bethencourt <luis@debethencourt.com> - 2015-09-18 21:20 +0200
  Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for  OF platform driver Alan Stern <stern@rowland.harvard.edu> - 2015-09-18 21:40 +0200
  Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for OF  platform driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-19 07:00 +0200

csiph-web