Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1228246
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [linux-sunxi] [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting for A23/A33 |
| Date | 2015-09-18 21:40 +0200 |
| Message-ID | <qa9FL-3Dm-19@gated-at.bofh.it> (permalink) |
| References | <q9YqZ-4pF-3@gated-at.bofh.it> <q9Yr1-4pF-21@gated-at.bofh.it> <qa5Vv-6Jf-7@gated-at.bofh.it> <qa6ye-7HP-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Sat, Sep 19, 2015 at 12:18:04AM +0800, Chen-Yu Tsai wrote:
> On Fri, Sep 18, 2015 at 11:30 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > Hi,
> >
> > On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote:
> >>
> >> The PWM controller has 2 outputs, with one usable pin for each.
> >>
> >> Add a pinmux setting for the first channel. This is often used
> >> for backlight dimming on tablets.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >> arch/arm/boot/dts/sun8i-a23-a33.dtsi | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> >> b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> >> index e7054304018a..8f4db82084c5 100644
> >> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> >> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> >> @@ -412,6 +412,13 @@
> >> allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >> };
> >>
> >> + pwm0_pins: pwm0 {
> >
> >
> > This should be "pwm0_pins_a: pwm0@0" so as to be consistent with the a10 /
> > a20 dtsi
> > files.
>
> This is the only possible setting. I do not see why we need "_a" for the
> label and "@0" for the name. IMHO they are used to avoid name clashes when
> there are multiple possible pinmux settings.
Yep, sounds reasonable, I applied the patch.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 0/4] ARM: dts: sun8i: Add pwm-backlight device for A23/A33 Q8 format tablets Chen-Yu Tsai <wens@csie.org> - 2015-09-18 09:40 +0200
[PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting for A23/A33 Chen-Yu Tsai <wens@csie.org> - 2015-09-18 09:40 +0200
Re: [linux-sunxi] [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting for A23/A33 Hans de Goede <hdegoede@redhat.com> - 2015-09-18 17:40 +0200
Re: [linux-sunxi] [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting for A23/A33 Chen-Yu Tsai <wens@csie.org> - 2015-09-18 18:20 +0200
Re: [linux-sunxi] [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting for A23/A33 Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-09-18 21:40 +0200
csiph-web