Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1228244

Re: tools build: Unused function, incomplete rename

Show all headers | View raw

Em Fri, Sep 18, 2015 at 04:23:34PM -0300, Arnaldo Carvalho de Melo escreveu:
> Hi Jiri, Ingo,
> 
> 	While trying to figure out why the bpf feature test is always
> triggering the display of the "Auto-detecting system features" I noticed
> this pattern:

Another problem, this time in how tools/lib/bpf/ specifies which
features to test for and which ones should have the feature detection
shown, does the following patch makes sense? I think it does because
FEATURE_TESTS looks like the ones that will be tested, and
FEATURE_DISPLAY the ones that will appear...:

diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index f68d23a0b487..604c12081b4b 100644
--- a/tools/lib/bpf/Makefile
+++ b/tools/lib/bpf/Makefile
@@ -64,8 +64,8 @@ srctree := $(patsubst %/,%,$(dir $(srctree)))
 #$(info Determined 'srctree' to be $(srctree))
 endif
 
-FEATURE_DISPLAY = libelf libelf-getphdrnum libelf-mmap bpf
-FEATURE_TESTS = libelf bpf
+FEATURE_TESTS = libelf libelf-getphdrnum libelf-mmap bpf
+FEATURE_DISPLAY = libelf bpf
 
 INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/arch/$(ARCH)/include/uapi -I$(srctree)/include/uapi
 FEATURE_CHECK_CFLAGS-bpf = $(INCLUDES)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

tools build: Unused function, incomplete rename Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-18 21:30 +0200
  Re: tools build: Unused function, incomplete rename Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-18 21:40 +0200
    Re: tools build: Unused function, incomplete rename Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-18 21:50 +0200
      Re: tools build: Unused function, incomplete rename Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-09-18 22:50 +0200
        Re: tools build: Unused function, incomplete rename Jiri Olsa <jolsa@redhat.com> - 2015-09-19 15:50 +0200
  Re: tools build: Unused function, incomplete rename Jiri Olsa <jolsa@redhat.com> - 2015-09-19 15:40 +0200

csiph-web