Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1328317
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Larry Finger <Larry.Finger@lwfinger.net> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. |
| Date | Sat, 06 Feb 2016 16:00:02 +0100 |
| Message-ID | <qZcv8-eX-11@gated-at.bofh.it> (permalink) |
| References | <qZcls-bk-3@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=3rRtWwg36mCpBHXtX8AX4RDmgMG2WYKMpQ84NSCDKvA=; b=BoL60IF3krlmBvE4ZvNgW8+Asi2J1McL730nswX5rf0u8SUQzH7vzeaiO8DWU6oaRk Hu+Lk7bJIwGWuj8xkEToruZ8N42f0LiDe+AKG5Mn/SyICoDTu7nNXPXe6Cn2f3N7YKS3 JOLhK/9EDln53P4jgtd2P5B5/052GC34UdvcuDCKfuj7PcL/2Vzd+ulMWLMfumA/+DAI bEcwv1GDmhSQfwcI5ZizJj1UeAkOt7zv6io8Fu0D6PqmJRYHdL8HqtgsYSGNOz6F+jEb 3GgaHUJ6ViqF3533PubYRNj8uWQv89RPTWUeWSguR6zB4p4p553kOtBkaK7wfkz53NvA AgBg== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=3rRtWwg36mCpBHXtX8AX4RDmgMG2WYKMpQ84NSCDKvA=; b=iWIyPuCj+9NKpeufZRSaTKaJp0Ma0jOmkwIlFgn9IJjU/VcplJoEF8ywRx6ebNXAQc iOnfaZzMVQekoK9TLjaqaAcyFWXG9zEwSQZ/P/V/mFkKAijREMHsjaUGkqAHpVCZGXLg ziUkKEW6dHdNEJu3Eh8DXMZl8lPlcerIAmzQNX/V5MdGfZMZndxCCPJ1cDCpqTrcdM8T B3J31QiZCCcy7oXD4fFSWsPumkIbA1GH58/9a6f3eh5UKJ9LY6ICMtpO2nKO36syiiQp tmZP9wKUnNkcAFWIEZWiQ/sklnZ7Yhf45rvbFGlhWc1zbdTWjbFin6TyHKE506jbcTjk Nj1w== |
| X-Gm-Message-State | AG10YOSSJIU8x41UBEr09nE1oSHFZK+4PnDLJ814+z2ANHB/nIaI3hyxr3sEuF7tGG7jKA== |
| X-Received | by 10.182.105.197 with SMTP id go5mr17281110obb.12.1454770440201; Sat, 06 Feb 2016 06:54:00 -0800 (PST) |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=windows-1252; format=flowed |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 36 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Sat, 6 Feb 2016 08:53:57 -0600 |
| X-Original-Message-ID | <56B60905.4090206@lwfinger.net> |
| X-Original-References | <20160206144111.GA86930@ubuntu> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1328317 |
Show key headers only | View raw
On 02/06/2016 08:41 AM, Pinkesh Badjatiya wrote:
> Fix Comparisons with constant on the left side of the test.
> Checkpatch.pl warning.
> --
> WARNING: Comparisons should place the constant on the right side of the
> test
> 296: FILE: ./rtl8712_cmd.c:296:
> while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) &&
>
> Signed-off-by: Pinkesh Badjatiya <pinkeshbadjatiya@gmail.com>
> ---
> drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This is another case where the writers of checkpatch are forcing their ideas of
style on the whole world. The problem is that if I reject your patch, it will be
submitted by someone else. Thus, reluctantly
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c
> index 9b91609..ce3f7da 100644
> --- a/drivers/staging/rtl8712/rtl8712_cmd.c
> +++ b/drivers/staging/rtl8712/rtl8712_cmd.c
> @@ -293,7 +293,7 @@ u8 r8712_fw_cmd(struct _adapter *pAdapter, u32 cmd)
>
> r8712_write32(pAdapter, IOCMD_CTRL_REG, cmd);
> msleep(100);
> - while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) &&
> + while ((r8712_read32(pAdapter, IOCMD_CTRL_REG) != 0) &&
> (pollingcnts > 0)) {
> pollingcnts--;
> msleep(20);
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: rtl8712: Fix Comparison with constant warning. Pinkesh Badjatiya <pinkeshbadjatiya@gmail.com> - 2016-02-06 15:50 +0100
Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. Larry Finger <Larry.Finger@lwfinger.net> - 2016-02-06 16:00 +0100
Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-08 04:50 +0100
Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-08 05:00 +0100
csiph-web