[PATCH] staging: rtl8712: Fix Comparison with constant warning.

From	Pinkesh Badjatiya <pinkeshbadjatiya@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: rtl8712: Fix Comparison with constant warning.
Date	2016-02-06 15:50 +0100
Message-ID	<qZcls-bk-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Fix Comparisons with constant on the left side of the test.
Checkpatch.pl warning.
--
WARNING: Comparisons should place the constant on the right side of the
test
296: FILE: ./rtl8712_cmd.c:296:
	while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) &&

Signed-off-by: Pinkesh Badjatiya <pinkeshbadjatiya@gmail.com>
---
 drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c
index 9b91609..ce3f7da 100644
--- a/drivers/staging/rtl8712/rtl8712_cmd.c
+++ b/drivers/staging/rtl8712/rtl8712_cmd.c
@@ -293,7 +293,7 @@ u8 r8712_fw_cmd(struct _adapter *pAdapter, u32 cmd)
 
 	r8712_write32(pAdapter, IOCMD_CTRL_REG, cmd);
 	msleep(100);
-	while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) &&
+	while ((r8712_read32(pAdapter, IOCMD_CTRL_REG) != 0) &&
 	       (pollingcnts > 0)) {
 		pollingcnts--;
 		msleep(20);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8712: Fix Comparison with constant warning. Pinkesh Badjatiya <pinkeshbadjatiya@gmail.com> - 2016-02-06 15:50 +0100
  Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. Larry Finger <Larry.Finger@lwfinger.net> - 2016-02-06 16:00 +0100
    Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-08 04:50 +0100
  Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-08 05:00 +0100

csiph-web