Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning.

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning.
Date	2016-02-08 05:00 +0100
Message-ID	<qZL9v-7QE-7@gated-at.bofh.it> (permalink)
References	<qZcls-bk-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Feb 06, 2016 at 08:11:11PM +0530, Pinkesh Badjatiya wrote:
> Fix Comparisons with constant on the left side of the test.
> Checkpatch.pl warning.
> --
> WARNING: Comparisons should place the constant on the right side of the
> test
> 296: FILE: ./rtl8712_cmd.c:296:
> 	while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) &&
> 
> Signed-off-by: Pinkesh Badjatiya <pinkeshbadjatiya@gmail.com>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>  drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Someone else sent this before you did, sorry :(

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8712: Fix Comparison with constant warning. Pinkesh Badjatiya <pinkeshbadjatiya@gmail.com> - 2016-02-06 15:50 +0100
  Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. Larry Finger <Larry.Finger@lwfinger.net> - 2016-02-06 16:00 +0100
    Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-08 04:50 +0100
  Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-08 05:00 +0100

csiph-web