Re: [PATCH v2] staging: unisys: use common return path

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] staging: unisys: use common return path
Date	Mon, 08 Feb 2016 18:20:02 +0100
Message-ID	<qZXDI-8ih-29@gated-at.bofh.it> (permalink)
References	<qAQP8-8w4-11@gated-at.bofh.it> <qZFGO-4aL-31@gated-at.bofh.it>
X-Original-To	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=CHeL/ibn4jgsiHI518WPn6XayDBqe7SeRE6cLa3UI70=; b=gE/sd9yISdCtG0kgWV6YNUSDm2HBvPHr93OfgVX2Mr/YmtjySMqHJLggnU9HEiq2pH jZaW0/3z76m/gW8cSrZD80lttWZG1voxe1C1z33hyBWawyyMDetgBJrDv0Jt/bEU8Kgq 9ns8b6FyOqOsKXCr0/diSoGPjSIDL28SB35Ut1GoRlJjne1lP174Bhzr/z1dXMx7kPQn IMhc8hUMDcm/GybPgiZsgdYhFpeLzrBhtS5M2LTJ6g3VD9vu6+je4QPZpIjRZiCHI90i 8DkIXsnmyulJNrLsPTXwecPyxB4herMdycOFl3dv/snTBws6UgQVGfthdF4SyVQZdBol 6Efw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=CHeL/ibn4jgsiHI518WPn6XayDBqe7SeRE6cLa3UI70=; b=PPfuu2Iar+iELCqUefsG2LgfJgrz855jZnP48tWBUNQL5pPHtM03jAubpmuG3DlQHg aWk7yH7MXbLa1Cq4npyODnXAVir0bRw9j/uwUWpqz8I7efcrZ2AnvVPbkEMGnssDQEzT sUJXpWfcEeEBc4fIWQ8EDyhR5cW1BmllmcdVgiCPssFd8xLdKsxPWKvWWl6i31me/QG6 242i+XyO9OnVFPGvYT4G7i8qa4KZYxL97v/Pp4N4XefAa3gn7BgCffmkp7fHHGBetgOG uEZhD+vVMagqIim9Crf9DsjIe6RjxPaxZLZfLv9JKaL+z8BrrJdLiF/6xtJ5cdc3Ixql GUBw==
X-Gm-Message-State	AG10YOQPLj+ntmRf0BfdVARlKndnmVTAyk+HtAniafBh6UgXtNPBdoFp5SNubhNOXDmQbw==
X-Received	by 10.66.100.135 with SMTP id ey7mr44425652pab.108.1454951825437; Mon, 08 Feb 2016 09:17:05 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	Benjamin Romer <benjamin.romer@unisys.com>, David Kershner <david.kershner@unisys.com>, devel@driverdev.osuosl.org, sparmaintainer@unisys.com, linux-kernel@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>
X-Original-Date	Mon, 8 Feb 2016 22:46:57 +0530
X-Original-Message-ID	<20160208171657.GB17609@sudip-laptop>
X-Original-References	<1448967153-14537-1-git-send-email-sudipm.mukherjee@gmail.com> <20160207220421.GB28175@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1329360

Show key headers only | View raw

On Sun, Feb 07, 2016 at 02:04:21PM -0800, Greg Kroah-Hartman wrote:
> On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote:
> > The success path and the error path both are first doing
> > spin_unlock_irqrestore() before returning. Use that in the common path
> > and return the success/error value.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> > 
> > v2: changed label name
> > 
> > It is dependent on the patch series sent by Benjamin (Nov 30th).
> 
> Which didn't get applied, so can you resend this after that does get
> accepted?

oops, i dont think i have the patch anymore. But looking at the commit
message, i think i just sent the same suggestion to Benjamin for his
[PATCH v3 13/14] staging: unisys: fix else statement in visornic_main.c

If he is not changing then I will create the patch and send you.

regards
sudip

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] staging: unisys: use common return path Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-07 23:10 +0100
  Re: [PATCH v2] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-08 18:20 +0100

csiph-web