Re: [PATCH] arm64: disable kasan when accessing frame->fp in unwind_frame

From	"Shi, Yang" <yang.shi@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: disable kasan when accessing frame->fp in unwind_frame
Date	2016-02-08 18:20 +0100
Message-ID	<qZXDI-8ih-27@gated-at.bofh.it> (permalink)
References	<qYXZ8-6YG-27@gated-at.bofh.it> <qZPPQ-2QD-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2/8/2016 12:51 AM, Andrey Ryabinin wrote:
>
>
> On 02/06/2016 02:04 AM, Yang Shi wrote:
>>
>>   #include <asm/irq.h>
>>   #include <asm/stacktrace.h>
>> @@ -64,7 +65,9 @@ int notrace unwind_frame(struct task_struct *tsk, struct stackframe *frame)
>>   		return -EINVAL;
>>
>>   	frame->sp = fp + 0x10;
>> +	kasan_disable_current();
>>   	frame->fp = *(unsigned long *)(fp);
>
> It would be better to use READ_ONCE_NOCHECK() here.
> See f7d27c35ddff7 ("x86/mm, kasan: Silence KASAN warnings in get_wchan()") which solves the same problem for x86.

Thanks for the suggestion, I'm going to try it soon.

>
>> +	kasan_enable_current();
>>   	frame->pc = *(unsigned long *)(fp + 8);
>
> Why you left frame->pc out of scope? This line could trigger kasan as well.

Actually, it was not reported as frequently as the first one. In my 
first a couple of boot test, it was not triggered before I came up with 
the patch. The first one is triggered every time.

It will be fixed in v2 too.

Thanks,
Yang

>
>>
>>   #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: disable kasan when accessing frame->fp in unwind_frame Yang Shi <yang.shi@linaro.org> - 2016-02-06 00:30 +0100
  Re: [PATCH] arm64: disable kasan when accessing frame->fp in  unwind_frame Andrey Ryabinin <aryabinin@virtuozzo.com> - 2016-02-08 10:00 +0100
    Re: [PATCH] arm64: disable kasan when accessing frame->fp in  unwind_frame "Shi, Yang" <yang.shi@linaro.org> - 2016-02-08 18:20 +0100

csiph-web