Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328629 > unrolled thread

Re: [PATCH v2] staging: unisys: use common return path

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] staging: unisys: use common return path Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-07 23:10 +0100
    Re: [PATCH v2] staging: unisys: use common return path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-08 18:20 +0100

#1328629 — Re: [PATCH v2] staging: unisys: use common return path

On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote:
> The success path and the error path both are first doing
> spin_unlock_irqrestore() before returning. Use that in the common path
> and return the success/error value.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> 
> v2: changed label name
> 
> It is dependent on the patch series sent by Benjamin (Nov 30th).

Which didn't get applied, so can you resend this after that does get
accepted?

thanks,

greg k-h

[toc] | [next] | [standalone]

#1329360

On Sun, Feb 07, 2016 at 02:04:21PM -0800, Greg Kroah-Hartman wrote:
> On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote:
> > The success path and the error path both are first doing
> > spin_unlock_irqrestore() before returning. Use that in the common path
> > and return the success/error value.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> > 
> > v2: changed label name
> > 
> > It is dependent on the patch series sent by Benjamin (Nov 30th).
> 
> Which didn't get applied, so can you resend this after that does get
> accepted?

oops, i dont think i have the patch anymore. But looking at the commit
message, i think i just sent the same suggestion to Benjamin for his
[PATCH v3 13/14] staging: unisys: fix else statement in visornic_main.c

If he is not changing then I will create the patch and send you.

regards
sudip

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web