Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1328743

Re: [PATCH v2] staging/dgap: move duplicated code from the dgap_cm.* functions

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] staging/dgap: move duplicated code from the dgap_cm.* functions
Date 2016-02-08 05:00 +0100
Message-ID <qZL9v-7QE-5@gated-at.bofh.it> (permalink)
References <qyMwj-12v-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Nov 25, 2015 at 11:51:21PM +0600, Alexander Kuleshov wrote:
> The dgap driver contains three functions: dgap_cmdb(), dgap_cmdw()
> and dgap_cmdw_exit which are contain duplicated code which waits
> if necessary before updating the pointer to limit outstanding
> commands. This patch introduces the wait_for_fep_cmds_limit()
> function which is will be called from these functions to prevent
> code duplication.
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> Forgot Signed-off-by line
> 
>  drivers/staging/dgap/dgap.c | 103 ++++++++++++++++----------------------------
>  1 file changed, 37 insertions(+), 66 deletions(-)

This driver is now deleted from the kernel tree, sorry :(

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v2] staging/dgap: move duplicated code from the dgap_cm.*  functions Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-08 05:00 +0100

csiph-web