Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1323057

Re: [PATCH] net: smc91x: propagate irq return code

Show all headers | View raw

Hello.

On 2/1/2016 1:46 AM, Robert Jarzmik wrote:

> The smc91x driver doesn't honor the probe deferral mechanism when the
> interrupt source is not yet available, such as one provided by a gpio
> controller not probed.
>
> Fix this by propagating the platform_get_irq() error code as the probe
> return value.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
>   drivers/net/ethernet/smsc/smc91x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index 0e2fc1a844ab..43ab7aa31a79 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -2343,7 +2343,7 @@ static int smc_drv_probe(struct platform_device *pdev)
>
>   	ndev->irq = platform_get_irq(pdev, 0);
>   	if (ndev->irq <= 0) {
> -		ret = -ENODEV;
> +		ret = ndev->irq;

    What if 'ndev->irq' does equal 0?

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: smc91x: propagate irq return code Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-31 23:50 +0100
  Re: [PATCH] net: smc91x: propagate irq return code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-01 13:40 +0100
    Re: [PATCH] net: smc91x: propagate irq return code Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-01 21:50 +0100
      Re: [PATCH] net: smc91x: propagate irq return code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-01 22:00 +0100
        Re: [PATCH] net: smc91x: propagate irq return code Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-01 22:10 +0100

csiph-web