Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1323484

Re: [PATCH] net: smc91x: propagate irq return code

Show all headers | View raw

Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:

> Hello.
>
> On 2/1/2016 1:46 AM, Robert Jarzmik wrote:
>
>> The smc91x driver doesn't honor the probe deferral mechanism when the
>> interrupt source is not yet available, such as one provided by a gpio
>> controller not probed.
>    What if 'ndev->irq' does equal 0?
That's not possible AFAIR.

There was a discussion where Linus had stated that the irq is a cookie, and a 0
value is "no interrupt", expcepting for the single case of a PC and its timer
interrupt.

As we're not in that case, and up to my understanding, platform_get_irq() cannot
return a 0 value, only a strictly negative or positive one.

And yet, that test now looks weird to me. I think I'll respin the patch with a
"if (ndev->irq < 0) {" instead of the "if (ndev->irq <= 0) {".

Cheers.

-- 
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: smc91x: propagate irq return code Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-31 23:50 +0100
  Re: [PATCH] net: smc91x: propagate irq return code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-01 13:40 +0100
    Re: [PATCH] net: smc91x: propagate irq return code Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-01 21:50 +0100
      Re: [PATCH] net: smc91x: propagate irq return code Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-01 22:00 +0100
        Re: [PATCH] net: smc91x: propagate irq return code Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-01 22:10 +0100

csiph-web