Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1323056

Re: [PATCH] adv7511: Added mode_fixup function.

Show all headers | View raw

Hi Laurent

On 29-01-2016 17:48, Laurent Pinchart wrote:
> Hi Carlos,
> 
> Thank you for the patch.
> 
> On Friday 29 January 2016 10:33:47 Carlos Palminha wrote:
>> The mode_fixup is necessary when using it in a DRM FB driver pipeline.
> 
> Instead of implementing stubs in encoder drivers, wouldn't it be better to 
> make mode_fixup optional ?
Probably you are right but i don't have enough knowledge or time to do that for the DRM framework. :(
I limited myself to do what the other drivers already implement.

The patch is mandatory to have to the ADV working or else will get some NULL pointer crash.

Regards,
C.Palminha

> 
>> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
>> ---
>>  drivers/gpu/drm/i2c/adv7511.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c
>> index 533d1e3..90082d2 100644
>> --- a/drivers/gpu/drm/i2c/adv7511.c
>> +++ b/drivers/gpu/drm/i2c/adv7511.c
>> @@ -648,6 +648,13 @@ adv7511_encoder_detect(struct drm_encoder *encoder,
>>  	return status;
>>  }
>>
>> +static bool adv7511_encoder_mode_fixup(struct drm_encoder *encoder,
>> +					const struct drm_display_mode *mode,
>> +					struct drm_display_mode *adjusted_mode)
>> +{
>> +	return true;
>> +}
>> +
>>  static int adv7511_encoder_mode_valid(struct drm_encoder *encoder,
>>  				      struct drm_display_mode *mode)
>>  {
>> @@ -754,6 +761,7 @@ static void adv7511_encoder_mode_set(struct drm_encoder
>> *encoder,
>>
>>  static const struct drm_encoder_slave_funcs adv7511_encoder_funcs = {
>>  	.dpms = adv7511_encoder_dpms,
>> +	.mode_fixup = adv7511_encoder_mode_fixup,
>>  	.mode_valid = adv7511_encoder_mode_valid,
>>  	.mode_set = adv7511_encoder_mode_set,
>>  	.detect = adv7511_encoder_detect,
> 


On 29-01-2016 17:48, Laurent Pinchart wrote:
> Hi Carlos,
> 
> Thank you for the patch.
> 
> On Friday 29 January 2016 10:33:47 Carlos Palminha wrote:
>> The mode_fixup is necessary when using it in a DRM FB driver pipeline.
> 
> Instead of implementing stubs in encoder drivers, wouldn't it be better to 
> make mode_fixup optional ?
> 
>> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
>> ---
>>  drivers/gpu/drm/i2c/adv7511.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c
>> index 533d1e3..90082d2 100644
>> --- a/drivers/gpu/drm/i2c/adv7511.c
>> +++ b/drivers/gpu/drm/i2c/adv7511.c
>> @@ -648,6 +648,13 @@ adv7511_encoder_detect(struct drm_encoder *encoder,
>>  	return status;
>>  }
>>
>> +static bool adv7511_encoder_mode_fixup(struct drm_encoder *encoder,
>> +					const struct drm_display_mode *mode,
>> +					struct drm_display_mode *adjusted_mode)
>> +{
>> +	return true;
>> +}
>> +
>>  static int adv7511_encoder_mode_valid(struct drm_encoder *encoder,
>>  				      struct drm_display_mode *mode)
>>  {
>> @@ -754,6 +761,7 @@ static void adv7511_encoder_mode_set(struct drm_encoder
>> *encoder,
>>
>>  static const struct drm_encoder_slave_funcs adv7511_encoder_funcs = {
>>  	.dpms = adv7511_encoder_dpms,
>> +	.mode_fixup = adv7511_encoder_mode_fixup,
>>  	.mode_valid = adv7511_encoder_mode_valid,
>>  	.mode_set = adv7511_encoder_mode_set,
>>  	.detect = adv7511_encoder_detect,
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] adv7511: Added mode_fixup function. Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2016-01-29 11:40 +0100
  Re: [PATCH] adv7511: Added mode_fixup function. Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-01-29 18:50 +0100
    Re: [PATCH] adv7511: Added mode_fixup function. Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2016-02-01 13:40 +0100
      Re: [PATCH] adv7511: Added mode_fixup function. Carlos Palminha <CARLOS.PALMINHA@synopsys.com> - 2016-02-04 16:30 +0100
        Re: [PATCH] adv7511: Added mode_fixup function. Lars-Peter Clausen <lars@metafoo.de> - 2016-02-04 21:40 +0100
          Re: [PATCH] adv7511: Added mode_fixup function. Daniel Vetter <daniel@ffwll.ch> - 2016-02-09 10:30 +0100

csiph-web