Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324621

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

From Willy Tarreau <w@1wt.eu>
Newsgroups linux.kernel
Subject Re: [PATCH v2] unix: properly account for FDs passed over unix sockets
Date 2016-02-02 22:00 +0100
Message-ID <qXQdk-cA-3@gated-at.bofh.it> (permalink)
References (3 earlier) <qXOXT-7QE-11@gated-at.bofh.it> <qXPTY-5z-15@gated-at.bofh.it> <qXQ3F-93-21@gated-at.bofh.it> <qXQdk-cA-1@gated-at.bofh.it> <qXQdk-cA-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 02, 2016 at 12:53:20PM -0800, Linus Torvalds wrote:
> On Tue, Feb 2, 2016 at 12:49 PM, Willy Tarreau <w@1wt.eu> wrote:
> > On Tue, Feb 02, 2016 at 12:44:54PM -0800, Linus Torvalds wrote:
> >>
> >> Umm. I think the "struct cred" may change in between, can't it?
> >
> > You mean for example in case of setuid() or something like this ?
> 
> Yeah. I'd be worried about looking up the creds or user structure
> later, and possibly getting a different one.
> 
> I'd much rather look it up at attach time, and just carry an extra
> pointer around. That seems to be an inherently safer model where
> there's no worry about "what happens if the user does X in the
> meantime".

Normally we can only change from root to non-root, and we don't apply
the limits to root, so if we have the ability to only store one bit
indicating "not tracked" or to simply nullify one pointer to avoid
counting in flight FDs for root, we don't take the risk to recredit
them to the target user after a change.

I just don't know if we can do that though :-/

Willy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets David Herrmann <dh.herrmann@gmail.com> - 2016-02-02 18:40 +0100
  Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-02 19:30 +0100
    Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-02 20:40 +0100
      Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Willy Tarreau <w@1wt.eu> - 2016-02-02 21:40 +0100
        Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-02 23:00 +0100
          Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 02:00 +0100
            Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 02:20 +0100
      Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-02 21:40 +0100
        Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-02 21:50 +0100
          Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Willy Tarreau <w@1wt.eu> - 2016-02-02 22:00 +0100
            Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Willy Tarreau <w@1wt.eu> - 2016-02-02 22:00 +0100
            Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-02 22:00 +0100
          Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-02 22:00 +0100
          RE: [PATCH v2] unix: properly account for FDs passed over unix  sockets David Laight <David.Laight@ACULAB.COM> - 2016-02-03 13:30 +0100
  Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Simon McVittie <simon.mcvittie@collabora.co.uk> - 2016-02-03 12:40 +0100
    Re: [PATCH v2] unix: properly account for FDs passed over unix sockets David Herrmann <dh.herrmann@gmail.com> - 2016-02-03 13:00 +0100
      Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Simon McVittie <simon.mcvittie@collabora.co.uk> - 2016-02-03 14:00 +0100
      Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 15:10 +0100
    Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 13:00 +0100

csiph-web