Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324607

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

Show all headers | View raw

On Tue, Feb 02, 2016 at 09:32:56PM +0100, Hannes Frederic Sowa wrote:
> But "struct pid *" in unix_skb_parms should be enough to get us to 
> corresponding "struct cred *" so we can decrement the correct counter 
> during skb destruction.
> 
> So:
> 
> We increment current task's unix_inflight and also check the current 
> task's limit during attaching fds to skbs and decrement the inflight 
> counter via "struct pid *". This looks like it should work.

I like it as well, the principle sounds sane.

> >That way it's always the person who actually does the send (rather
> >than the opener of the socket _or_ the opener of the file that gets
> >passed around) that gets credited, and thanks to the cred pointer we
> >can then de-credit them properly.
> 
> Exactly, I try to implement that. Thanks a lot!

Thanks to you Hannes, I appreciate that you work on it, it would take
much more time to me to dig into this.

Willy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets David Herrmann <dh.herrmann@gmail.com> - 2016-02-02 18:40 +0100
  Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-02 19:30 +0100
    Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-02 20:40 +0100
      Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Willy Tarreau <w@1wt.eu> - 2016-02-02 21:40 +0100
        Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-02 23:00 +0100
          Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 02:00 +0100
            Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 02:20 +0100
      Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-02 21:40 +0100
        Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-02 21:50 +0100
          Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Willy Tarreau <w@1wt.eu> - 2016-02-02 22:00 +0100
            Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Willy Tarreau <w@1wt.eu> - 2016-02-02 22:00 +0100
            Re: [PATCH v2] unix: properly account for FDs passed over unix sockets Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-02 22:00 +0100
          Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-02 22:00 +0100
          RE: [PATCH v2] unix: properly account for FDs passed over unix  sockets David Laight <David.Laight@ACULAB.COM> - 2016-02-03 13:30 +0100
  Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Simon McVittie <simon.mcvittie@collabora.co.uk> - 2016-02-03 12:40 +0100
    Re: [PATCH v2] unix: properly account for FDs passed over unix sockets David Herrmann <dh.herrmann@gmail.com> - 2016-02-03 13:00 +0100
      Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Simon McVittie <simon.mcvittie@collabora.co.uk> - 2016-02-03 14:00 +0100
      Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 15:10 +0100
    Re: [PATCH v2] unix: properly account for FDs passed over unix  sockets Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 13:00 +0100

csiph-web