Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318739

Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs

Show all headers | View raw

Am 27.01.2016 um 00:34 schrieb Florian Fainelli:
> On 25/01/16 14:24, Richard Weinberger wrote:
>> Not every arch has io memory.
>> So, unbreak the build by fixing the dependencies.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>>  drivers/power/reset/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
>> index 1131cf7..0a6408a 100644
>> --- a/drivers/power/reset/Kconfig
>> +++ b/drivers/power/reset/Kconfig
>> @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE
>>  config POWER_RESET_SYSCON
>>  	bool "Generic SYSCON regmap reset driver"
>>  	depends on OF
>> +	depends on HAS_IOMEM
>>  	select MFD_SYSCON
> 
> Should this dependency go into REGMAP_MMIO instead? MFD_SYSCON in itself
> does not issue I/O accesses per-se, but does use helpers from regmap,
> which in turn do it.

Hmmm, AFAICT this would not work as REGMAP_MMIO is not user visible and directly enabled
via "select" instead of "depends on". Hence, dependencies are ignored.

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

(none) Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
  [PATCH 12/22] nvmem: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 12/22] nvmem: Fix dependencies for !HAS_IOMEM archs Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-01-26 12:20 +0100
      Re: [PATCH 12/22] nvmem: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-26 15:30 +0100
  [PATCH 18/22] irqchip: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    [tip:irq/urgent] irqchip: Fix dependencies for archs w/  o HAS_IOMEM tip-bot for Richard Weinberger <tipbot@zytor.com> - 2016-01-26 16:10 +0100
  [PATCH 19/22] thermal: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
  [PATCH 02/22] phy: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
  [PATCH 20/22] clocksource: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    [tip:timers/urgent] clocksource: Fix dependencies for archs w/  o HAS_IOMEM tip-bot for Richard Weinberger <tipbot@zytor.com> - 2016-01-26 16:50 +0100
  [PATCH 15/22] watchdog: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 15/22] watchdog: Fix dependencies for !HAS_IOMEM archs Guenter Roeck <linux@roeck-us.net> - 2016-01-26 03:50 +0100
  [PATCH 10/22] mailbox: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
  [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-26 12:10 +0100
      Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-26 15:00 +0100
  [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs Paul Bolle <pebolle@tiscali.nl> - 2016-01-26 01:20 +0100
      Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-26 09:20 +0100
  [PATCH 05/22] hw_random: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 05/22] hw_random: Fix dependencies for !HAS_IOMEM archs Daniel Thompson <daniel.thompson@linaro.org> - 2016-01-26 11:00 +0100
    Re: [PATCH 05/22] hw_random: Fix dependencies for !HAS_IOMEM archs Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-26 15:50 +0100
  [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
    Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Florian Fainelli <f.fainelli@gmail.com> - 2016-01-27 00:40 +0100
      Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-27 09:10 +0100
  [PATCH 06/22] iio: adc: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
  [PATCH 07/22] fpga: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
    Re: [PATCH 07/22] fpga: Fix dependencies for !HAS_IOMEM archs Moritz Fischer <moritz.fischer@ettus.com> - 2016-01-26 00:40 +0100
  [PATCH 08/22] hwtracing: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
  [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
    Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA  archs John Garry <john.garry@huawei.com> - 2016-01-26 11:20 +0100
      Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA  archs Richard Weinberger <richard@nod.at> - 2016-01-26 11:40 +0100
        Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA  archs John Garry <john.garry@huawei.com> - 2016-01-26 12:00 +0100
          Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-27 03:20 +0100
  [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
    Re: [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-26 12:00 +0100

csiph-web