Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1317930
| From | Richard Weinberger <richard@nod.at> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs |
| Date | 2016-01-26 15:00 +0100 |
| Message-ID | <qVck2-4Sm-13@gated-at.bofh.it> (permalink) |
| References | <qUXO2-2e8-9@gated-at.bofh.it> <qUXO4-2e8-53@gated-at.bofh.it> <qV9Fx-3em-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Geert,
Am 26.01.2016 um 12:00 schrieb Geert Uytterhoeven:
> Hi Richard,
>
> On Mon, Jan 25, 2016 at 11:24 PM, Richard Weinberger <richard@nod.at> wrote:
>> Not every arch has io memory nor can this driver ever work
>> on UML/i386.
>> So, unbreak the build by fixing the dependencies.
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/mtd/nand/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index 545d82b..b253654 100644
>> --- a/drivers/mtd/nand/Kconfig
>> +++ b/drivers/mtd/nand/Kconfig
>> @@ -311,6 +311,7 @@ config MTD_NAND_CAFE
>> config MTD_NAND_CS553X
>> tristate "NAND support for CS5535/CS5536 (AMD Geode companion chip)"
>> depends on X86_32
>> + depends on !UML && HAS_IOMEM
>
> I don't think there's a need for the !UML dependency?
> Hence just "depends on X86_32 && HAS_IOMEM"?
Strictly speaking this would work as HAS_IOMEM implies !UML.
The build error shows that it fails also because UML/i386 is x86_32
but lacks some x86_32 stuff:
drivers/mtd/nand/cs553x_nand.c: In function ‘cs553x_init_one’:
drivers/mtd/nand/cs553x_nand.c:212:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
this->IO_ADDR_R = this->IO_ADDR_W = ioremap(adr, 4096);
^
drivers/mtd/nand/cs553x_nand.c:212:36: warning: assignment makes pointer from integer without a cast [enabled by default]
this->IO_ADDR_R = this->IO_ADDR_W = ioremap(adr, 4096);
^
drivers/mtd/nand/cs553x_nand.c:256:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(this->IO_ADDR_R);
^
drivers/mtd/nand/cs553x_nand.c: In function ‘is_geode’:
drivers/mtd/nand/cs553x_nand.c:266:19: error: ‘struct cpuinfo_um’ has no member named ‘x86_vendor’
if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD &&
^
drivers/mtd/nand/cs553x_nand.c:266:34: error: ‘X86_VENDOR_AMD’ undeclared (first use in this function)
if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD &&
^
drivers/mtd/nand/cs553x_nand.c:266:34: note: each undeclared identifier is reported only once for each function it appears in
drivers/mtd/nand/cs553x_nand.c:267:19: error: ‘struct cpuinfo_um’ has no member named ‘x86’
boot_cpu_data.x86 == 5 &&
^
drivers/mtd/nand/cs553x_nand.c:268:19: error: ‘struct cpuinfo_um’ has no member named ‘x86_model’
boot_cpu_data.x86_model == 10)
^
drivers/mtd/nand/cs553x_nand.c:271:20: error: ‘struct cpuinfo_um’ has no member named ‘x86_vendor’
if ((boot_cpu_data.x86_vendor == X86_VENDOR_NSC ||
^
drivers/mtd/nand/cs553x_nand.c:271:35: error: ‘X86_VENDOR_NSC’ undeclared (first use in this function)
if ((boot_cpu_data.x86_vendor == X86_VENDOR_NSC ||
^
drivers/mtd/nand/cs553x_nand.c:272:20: error: ‘struct cpuinfo_um’ has no member named ‘x86_vendor’
boot_cpu_data.x86_vendor == X86_VENDOR_CYRIX) &&
^
drivers/mtd/nand/cs553x_nand.c:272:35: error: ‘X86_VENDOR_CYRIX’ undeclared (first use in this function)
boot_cpu_data.x86_vendor == X86_VENDOR_CYRIX) &&
^
drivers/mtd/nand/cs553x_nand.c:273:19: error: ‘struct cpuinfo_um’ has no member named ‘x86’
boot_cpu_data.x86 == 5 &&
^
drivers/mtd/nand/cs553x_nand.c:274:19: error: ‘struct cpuinfo_um’ has no member named ‘x86_model’
boot_cpu_data.x86_model == 5)
Maybe a "depends on X86_32 && !UML" would make more sense. hmm?
Thanks,
//richard
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
(none) Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
[PATCH 12/22] nvmem: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
Re: [PATCH 12/22] nvmem: Fix dependencies for !HAS_IOMEM archs Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-01-26 12:20 +0100
Re: [PATCH 12/22] nvmem: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-26 15:30 +0100
[PATCH 18/22] irqchip: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
[tip:irq/urgent] irqchip: Fix dependencies for archs w/ o HAS_IOMEM tip-bot for Richard Weinberger <tipbot@zytor.com> - 2016-01-26 16:10 +0100
[PATCH 19/22] thermal: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
[PATCH 02/22] phy: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
[PATCH 20/22] clocksource: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
[tip:timers/urgent] clocksource: Fix dependencies for archs w/ o HAS_IOMEM tip-bot for Richard Weinberger <tipbot@zytor.com> - 2016-01-26 16:50 +0100
[PATCH 15/22] watchdog: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
Re: [PATCH 15/22] watchdog: Fix dependencies for !HAS_IOMEM archs Guenter Roeck <linux@roeck-us.net> - 2016-01-26 03:50 +0100
[PATCH 10/22] mailbox: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
[PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-26 12:10 +0100
Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-26 15:00 +0100
[PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs Paul Bolle <pebolle@tiscali.nl> - 2016-01-26 01:20 +0100
Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-26 09:20 +0100
[PATCH 05/22] hw_random: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
Re: [PATCH 05/22] hw_random: Fix dependencies for !HAS_IOMEM archs Daniel Thompson <daniel.thompson@linaro.org> - 2016-01-26 11:00 +0100
Re: [PATCH 05/22] hw_random: Fix dependencies for !HAS_IOMEM archs Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-26 15:50 +0100
[PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Florian Fainelli <f.fainelli@gmail.com> - 2016-01-27 00:40 +0100
Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-27 09:10 +0100
[PATCH 06/22] iio: adc: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
[PATCH 07/22] fpga: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
Re: [PATCH 07/22] fpga: Fix dependencies for !HAS_IOMEM archs Moritz Fischer <moritz.fischer@ettus.com> - 2016-01-26 00:40 +0100
[PATCH 08/22] hwtracing: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
[PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs John Garry <john.garry@huawei.com> - 2016-01-26 11:20 +0100
Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Richard Weinberger <richard@nod.at> - 2016-01-26 11:40 +0100
Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs John Garry <john.garry@huawei.com> - 2016-01-26 12:00 +0100
Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-27 03:20 +0100
[PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
Re: [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-26 12:00 +0100
csiph-web