Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs
Date	2016-01-26 09:20 +0100
Message-ID	<qV710-1ma-9@gated-at.bofh.it> (permalink)
References	<qUXO2-2e8-9@gated-at.bofh.it> <qUXO4-2e8-57@gated-at.bofh.it> <qUZwv-3tl-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 26.01.2016 um 01:15 schrieb Paul Bolle:
> On ma, 2016-01-25 at 23:24 +0100, Richard Weinberger wrote:
>> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
>> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig
> 
>>  config INV_MPU6050_IIO
>>  	tristate "Invensense MPU6050 devices"
>>  	depends on I2C && SYSFS
>> +	depends on I2C_MUX
> 
> Nit: if I parsed the v4.5-rc1 tree correctly I2C_MUX depends I2C. So
> just
> 	depends on I2C_MUX && SYSFS
> 
> should also do the trick. Is it clearer to mention both I2C and I2C_MUX
> explicitly?

I don't have a strong opinion on that. In general I'm a fan of explicit
dependencies but in this case, you are right, also an implicit one should to it.
Let's see what maintainers think. :-)

Thanks,
//richard

Thread

(none) Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
  [PATCH 12/22] nvmem: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 12/22] nvmem: Fix dependencies for !HAS_IOMEM archs Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-01-26 12:20 +0100
      Re: [PATCH 12/22] nvmem: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-26 15:30 +0100
  [PATCH 18/22] irqchip: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    [tip:irq/urgent] irqchip: Fix dependencies for archs w/  o HAS_IOMEM tip-bot for Richard Weinberger <tipbot@zytor.com> - 2016-01-26 16:10 +0100
  [PATCH 19/22] thermal: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
  [PATCH 02/22] phy: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
  [PATCH 20/22] clocksource: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    [tip:timers/urgent] clocksource: Fix dependencies for archs w/  o HAS_IOMEM tip-bot for Richard Weinberger <tipbot@zytor.com> - 2016-01-26 16:50 +0100
  [PATCH 15/22] watchdog: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 15/22] watchdog: Fix dependencies for !HAS_IOMEM archs Guenter Roeck <linux@roeck-us.net> - 2016-01-26 03:50 +0100
  [PATCH 10/22] mailbox: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
  [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-26 12:10 +0100
      Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-26 15:00 +0100
  [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs Paul Bolle <pebolle@tiscali.nl> - 2016-01-26 01:20 +0100
      Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-26 09:20 +0100
  [PATCH 05/22] hw_random: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:30 +0100
    Re: [PATCH 05/22] hw_random: Fix dependencies for !HAS_IOMEM archs Daniel Thompson <daniel.thompson@linaro.org> - 2016-01-26 11:00 +0100
    Re: [PATCH 05/22] hw_random: Fix dependencies for !HAS_IOMEM archs Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-26 15:50 +0100
  [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
    Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Florian Fainelli <f.fainelli@gmail.com> - 2016-01-27 00:40 +0100
      Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-27 09:10 +0100
  [PATCH 06/22] iio: adc: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
  [PATCH 07/22] fpga: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
    Re: [PATCH 07/22] fpga: Fix dependencies for !HAS_IOMEM archs Moritz Fischer <moritz.fischer@ettus.com> - 2016-01-26 00:40 +0100
  [PATCH 08/22] hwtracing: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
  [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
    Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA  archs John Garry <john.garry@huawei.com> - 2016-01-26 11:20 +0100
      Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA  archs Richard Weinberger <richard@nod.at> - 2016-01-26 11:40 +0100
        Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA  archs John Garry <john.garry@huawei.com> - 2016-01-26 12:00 +0100
          Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-27 03:20 +0100
  [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs Richard Weinberger <richard@nod.at> - 2016-01-25 23:40 +0100
    Re: [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-26 12:00 +0100

csiph-web