Groups > linux.kernel > #1320716

Re: [PATCH V2] netfilter: h323: avoid potential attack

From	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] netfilter: h323: avoid potential attack
Date	2016-01-28 15:20 +0100
Message-ID	<qVVAt-4Ce-3@gated-at.bofh.it> (permalink)
References	<qVUO6-3Yo-29@gated-at.bofh.it> <qVUO6-3Yo-31@gated-at.bofh.it> <qVUO6-3Yo-27@gated-at.bofh.it> <qVVqO-4wq-7@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

On Thu, 28 Jan 2016 06:00:50 -0800
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> On Thu, 2016-01-28 at 21:14 +0800, Zhouyi Zhou wrote:
> 
> > My patch is intend to prevent kernel panic, to prevent reading garbage
> > or read data from a prior frame and leak secrets, the prototypes of the 
> > get_h2x5_addr functions and the functions that call get_h2x5_addr should
> > be changed, should we do this?   
> 
> In term of security, panics are better than allowing attacker to read
> data from other people, like a password.
> 
> BTW, are you able to trigger any panic ?

We have a smattering of panics in this code in bugzilla going back years.

https://bugzilla.kernel.org/show_bug.cgi?id=12473

etc

Alan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: Re: [PATCH V2] netfilter: h323: avoid potential attack "Zhouyi Zhou" <yizhouzhou@ict.ac.cn> - 2016-01-28 14:30 +0100
  Re: Re: [PATCH V2] netfilter: h323: avoid potential attack Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-28 15:10 +0100
    Re: Re: [PATCH V2] netfilter: h323: avoid potential attack Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-28 15:10 +0100
    Re: [PATCH V2] netfilter: h323: avoid potential attack One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-01-28 15:20 +0100

csiph-web