Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320713

Re: Re: [PATCH V2] netfilter: h323: avoid potential attack

Show all headers | View raw

On Thu, 2016-01-28 at 06:00 -0800, Eric Dumazet wrote:
> On Thu, 2016-01-28 at 21:14 +0800, Zhouyi Zhou wrote:
> 
> > My patch is intend to prevent kernel panic, to prevent reading garbage
> > or read data from a prior frame and leak secrets, the prototypes of the 
> > get_h2x5_addr functions and the functions that call get_h2x5_addr should
> > be changed, should we do this? 
> 
> In term of security, panics are better than allowing attacker to read
> data from other people, like a password.
> 
> BTW, are you able to trigger any panic ?
> 
> I am not familiar with this code, it is not obvious.
> 
> If a fix is needed, better doing it right.
> 


BTW, this module is protected by a lock (nf_h323_lock)

So adding a variable like 'h323_buffer_valid_bytes' that would contain
the number of valid bytes would not require to change prototypes.

This variable would be written when skb_header_pointer() is used in
get_tpkt_data() / get_udp_data()

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Re: [PATCH V2] netfilter: h323: avoid potential attack "Zhouyi Zhou" <yizhouzhou@ict.ac.cn> - 2016-01-28 14:30 +0100
  Re: Re: [PATCH V2] netfilter: h323: avoid potential attack Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-28 15:10 +0100
    Re: Re: [PATCH V2] netfilter: h323: avoid potential attack Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-28 15:10 +0100
    Re: [PATCH V2] netfilter: h323: avoid potential attack One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-01-28 15:20 +0100

csiph-web