Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320479 > unrolled thread
| Started by | chenfeng <puck.chen@hisilicon.com> |
|---|---|
| First post | 2016-01-28 10:50 +0100 |
| Last post | 2016-01-28 12:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver chenfeng <puck.chen@hisilicon.com> - 2016-01-28 10:50 +0100
Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver Lee Jones <lee.jones@linaro.org> - 2016-01-28 12:40 +0100
| From | chenfeng <puck.chen@hisilicon.com> |
|---|---|
| Date | 2016-01-28 10:50 +0100 |
| Subject | Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver |
| Message-ID | <qVRnd-1sZ-19@gated-at.bofh.it> |
Hi Lee,
Thanks for your review!
There is one things need your confirm.
Please help to see it below.
On 2016/1/25 22:22, Lee Jones wrote:
> On Mon, 11 Jan 2016, Chen Feng wrote:
>
>> Add pmic mfd driver to support hisilicon hi665x.
[..]
>
>> +static const struct mfd_cell hi655x_pmic_devs[] = {
>> + { .name = "hi655x-regulator", },
>> +};
>
> What other devices are there?
>
Current the MFD PMIC driver only has regulator enable.
The RTC & Power-key are not in these patch sets.
They will be added later.
Will this be accepted?
>> +static const struct regmap_irq hi655x_irqs[] = {
>> + { .reg_offset = 0, .mask = OTMP_D1R_INT },
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-01-28 12:40 +0100 |
| Message-ID | <qVT5E-2Js-15@gated-at.bofh.it> |
| In reply to | #1320479 |
On Thu, 28 Jan 2016, chenfeng wrote:
> Hi Lee,
>
> Thanks for your review!
> There is one things need your confirm.
> Please help to see it below.
>
> On 2016/1/25 22:22, Lee Jones wrote:
> > On Mon, 11 Jan 2016, Chen Feng wrote:
> >
> >> Add pmic mfd driver to support hisilicon hi665x.
> [..]
>
> >
> >> +static const struct mfd_cell hi655x_pmic_devs[] = {
> >> + { .name = "hi655x-regulator", },
> >> +};
> >
> > What other devices are there?
> >
>
> Current the MFD PMIC driver only has regulator enable.
>
> The RTC & Power-key are not in these patch sets.
>
> They will be added later.
>
> Will this be accepted?
Yes.
> >> +static const struct regmap_irq hi655x_irqs[] = {
> >> + { .reg_offset = 0, .mask = OTMP_D1R_INT },
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web