Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator
Date	2016-02-02 20:40 +0100
Message-ID	<qXOXU-7QE-27@gated-at.bofh.it> (permalink)
References	(3 earlier) <qVZkK-7kv-17@gated-at.bofh.it> <qW414-2cO-13@gated-at.bofh.it> <qWe0q-OA-9@gated-at.bofh.it> <qWfpw-28O-21@gated-at.bofh.it> <qWgbT-2Qe-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Jan 29, 2016 at 08:11:19PM +0800, menghui lin wrote:
> On Fri, 2016-01-29 at 12:27 +0100, Mark Brown wrote:

> > None of this is answering my question - I know what the current API is,
> > describing it doesn't tell me about actual users or how they are able to
> > sensibly use the interface.  Bear in mind that the definitions of the
> > various modes are all relative and what one device thinks is high usage
> > may be low usage for another device.

> Assuming valid_modes_mask and initial_mode are specified, a possible
> way to modify regulator_set_mode() is to allow mode change only if the
> regulator is controlled exclusively by a certain consumer or the
> requested mode provides stronger power capability than current mode.
> Here I assume that power capability fast > normal > idle > standby.

How does the driver know if it needs to change the mode (ie, how can it
tell if the current mode is inadequate) and surely if we can only change
in one direction this isn't terribly useful?

Thread

Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator John Crispin <blogic@openwrt.org> - 2016-01-28 19:20 +0100
  Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-29 00:20 +0100
    Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-01-29 11:00 +0100
      Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-29 12:30 +0100
        Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-01-29 13:20 +0100
          Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-02-02 20:40 +0100
          Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-02-02 20:40 +0100
            Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-02-03 06:40 +0100
              Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-02-03 13:40 +0100
                Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-02-04 03:50 +0100

csiph-web